Skip to content

Better args handling for Dedup - #10

Open
ReallyLiri wants to merge 2 commits into
paul-mannino:masterfrom
ReallyLiri:master
Open

Better args handling for Dedup#10
ReallyLiri wants to merge 2 commits into
paul-mannino:masterfrom
ReallyLiri:master

Conversation

@ReallyLiri

Copy link
Copy Markdown

the original code has a bug, the cast check is flipped:

t, err := arg.(int)
if err ...

should be

t, ok := arg.(int)
if !ok ...

But anyway changed to a more go styled code

@paul-mannino

Copy link
Copy Markdown
Owner

Thanks for the PR & bug fix. Would you mind adding a couple tests that exercise these optional args? Coverage seems a little lacking for those code paths currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants