Skip to content

added onPhoneNumberFocus handler - #239

Open
ucozlab wants to merge 1 commit into
patw0929:masterfrom
ucozlab:feature/onfocus-handler
Open

added onPhoneNumberFocus handler#239
ucozlab wants to merge 1 commit into
patw0929:masterfrom
ucozlab:feature/onfocus-handler

Conversation

@ucozlab

@ucozlab ucozlab commented Oct 28, 2018

Copy link
Copy Markdown

I need to make some actions in my app on every input focus, so could you pls add the "onFocus" handler? Thanks!

@tomegz

tomegz commented Dec 16, 2018

Copy link
Copy Markdown
Contributor

Have you tried passing onFocus with inputProps?

@ucozlab

ucozlab commented Dec 17, 2018 via email

Copy link
Copy Markdown
Author

@nazarlitvin

Copy link
Copy Markdown

Hi guys, do you need any help with this PR? It would be great to have onFocus handler!

@ucozlab

ucozlab commented May 7, 2019

Copy link
Copy Markdown
Author

yes, I need @tomegz to check why the tests are failed and approve this PR

@Tomlgls

Tomlgls commented May 15, 2019

Copy link
Copy Markdown

+1

@tomegz

tomegz commented May 15, 2019

Copy link
Copy Markdown
Contributor

You should first resolve the conflicts and make your branch up to date. Maybe the tests will stop failing then. Also, looking through the code it seems really weird that it doesn't work for you if you pass it like this:

const inputProps = {
  onFocus: yourOnFocusHandler,
};

<IntlTelInput inputProps={inputProps} />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants