Fix for API change in Padre 0.85

[martink]

Hi Patrick,

Long time no see. I suppose you'll enjoy working at Google. Anyway, I fixed a bug in the WebGUI Padre plugin that was being caused by Adam Kenedy changing the Padre API. I you have time, why not pull it in =)

Please note that doing this will make the plugin compatible only with Padre 0.85 and up, because in that version the change was made.

Good luck, and if you feel like trying out the Dutch dunnies one day, fly over to Ducthland and I'll show you the best ones we have. After a couple of double fisting sessions, of course.

Cheers,

Martin

[patspam]

Hey Martin - will pull it in for sure but give me a few days, currently
recovering from a fractured face. Played indoor soccer as the goal keeper
and decided to stop a guy with my cheek bone...

On Fri, Sep 16, 2011 at 12:32 PM, Martin Kamerbeek <
reply@reply.github.com>wrote:

Hi Patrick,

Long time no see. I suppose you'll enjoy working at Google. Anyway, I fixed
a bug in the WebGUI Padre plugin that was being caused by Adam Kenedy
changing the Padre API. I you have time, why not pull it in =)

Please note that doing this will make the plugin compatible only with Padre
0.85 and up, because in that version the change was made.

Good luck, and if you feel like trying out the Dutch dunnies one day, fly
over to Ducthland and I'll show you the best ones we have. After a couple of
double fisting sessions, of course.

Cheers,

Martin

You can merge this Pull Request by running:

git pull https://github.com/martink/Padre-Plugin-WebGUI master

Or you can view, comment on it, or merge it online at:

#2

-- Commit Summary --

• Fixing bug caused by Padre API change in 0.85

-- File Changes --

M Changes (1)
M dist.ini (2)
M lib/Padre/Plugin/WebGUI/Assets.pm (2)

-- Patch Links --

https://github.com/pdonelan/Padre-Plugin-WebGUI/pull/2.patch
https://github.com/pdonelan/Padre-Plugin-WebGUI/pull/2.diff

Reply to this email directly or view it on GitHub:
#2

[patspam]

Hey Martin,

Sorry for the delay - I gave you co-maintenance status on the CPAN module
so that you can patch and release it yourself. The code lives in the Padre
SVN repo (the git repo is just a stale copy) so feel free to hack it up
however you like. I'm working off a Mac at the moment and haven't been able
to get Padre to build so I'm not sure how soon I'll be able to merge in
your changes myself...

..also just arrived in Australia for a 6 week holiday so I'm probably going
to be distracted double-fisting with tradies.

Patrick

On Thu, Sep 22, 2011 at 1:49 AM, Patrick Donelan pat@patspam.com wrote:

Hey Martin - will pull it in for sure but give me a few days, currently
recovering from a fractured face. Played indoor soccer as the goal keeper
and decided to stop a guy with my cheek bone...

On Fri, Sep 16, 2011 at 12:32 PM, Martin Kamerbeek <
reply@reply.github.com>wrote:

Hi Patrick,

Long time no see. I suppose you'll enjoy working at Google. Anyway, I
fixed a bug in the WebGUI Padre plugin that was being caused by Adam Kenedy
changing the Padre API. I you have time, why not pull it in =)

Please note that doing this will make the plugin compatible only with
Padre 0.85 and up, because in that version the change was made.

Good luck, and if you feel like trying out the Dutch dunnies one day, fly
over to Ducthland and I'll show you the best ones we have. After a couple
of double fisting sessions, of course.

Cheers,

Martin

You can merge this Pull Request by running:

git pull https://github.com/martink/Padre-Plugin-WebGUI master

Or you can view, comment on it, or merge it online at:

#2

-- Commit Summary --

• Fixing bug caused by Padre API change in 0.85

-- File Changes --

M Changes (1)
M dist.ini (2)
M lib/Padre/Plugin/WebGUI/Assets.pm (2)

-- Patch Links --

https://github.com/pdonelan/Padre-Plugin-WebGUI/pull/2.patch
https://github.com/pdonelan/Padre-Plugin-WebGUI/pull/2.diff

Reply to this email directly or view it on GitHub:
#2