Tuning detection - #9
Merged
Merged
Conversation
- Added tuning detection functionality in the audio engine, allowing for automatic measurement of the song's reference A4. - Introduced new types and commands for pitch-related events in the messaging protocol. - Updated the session state management to handle tuning detection status and results. - Enhanced the PitchPanel UI with a DetectButton for initiating tuning detection, including visual feedback for detecting state and results. - Created a new DetectButton component for shared use in both pitch and speed panels. - Implemented tests for tuning detection logic to ensure accuracy and reliability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes, and what a user notices
How it was tested
pnpm dev)node e2e/run.mjs— required if this touches the DSP or the connectionstate machine. The suite is not all-green; compare against a clean
checkout rather than assuming your change caused a failure.
*.worklet.tsorcenter-cut-dsp.tschangedAnything you are unsure about