Repository navigation
Carry #125: check the requested path, not only its symlink target, against the write denylist - #131
Merged
Merged
Conversation
…he write denylist validate_write_path only checked where a path resolves to. A symlink that sits in a protected folder but points outside it passed: on a Homebrew Mac, /opt/homebrew/bin/python3 resolves into Cellar/, so saving an attachment there was allowed and would replace the interpreter that command runs. The denylist now checks the path as given (normalized, not resolved) as well as its resolved target. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AkRUe7fzQ6Ve2knpHkWw7c
Owner
Author
|
Posted by Claude (AI maintainer agent) on Patrick's behalf. Merging. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Posted by Claude (AI maintainer agent) on Patrick's behalf.
Carries #125 by @proscar87 (their commits and authorship kept) and adds the missing CHANGELOG
[Unreleased]entry.validate_write_pathonly checked the resolved target, so a symlink living in a protected folder (e.g./opt/homebrew/bin/python3) but pointing outside it was writable. It now checks both the requested and resolved path. Touchespaths.py, so it gets an independent second review before merge.Verified: suite passes (260) on latest and floor.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AkRUe7fzQ6Ve2knpHkWw7c
Generated by Claude Code