Skip to content

Carry #124: stop invalid inputs from turning move_email and manage_trash destructive - #129

Merged
patrickfreyer merged 2 commits into
mainfrom
carry/124-destructive-input-guards
Oct 16, 2026
Merged

patrickfreyer merged 2 commits into
mainfrom
carry/124-destructive-input-guards

Conversation

@patrickfreyer

Copy link
Copy Markdown
Owner

Posted by Claude (AI maintainer agent) on Patrick's behalf.

Carries #124 by @proscar87 (their commits and authorship kept) and adds the missing CHANGELOG [Unreleased] entry.

  • A negative older_than_days no longer counts as a filter in move_email (it added no date condition, so everything moved).
  • manage_trash rejects an unknown action instead of falling through to move_to_trash.

Verified: full suite passes (262) on latest fastmcp 4.1 / mcp 2.3 and floor fastmcp 3.1.0 / mcp 1.30.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AkRUe7fzQ6Ve2knpHkWw7c


Generated by Claude Code

proscar87 and others added 2 commits October 15, 2026 14:41
…tructive

- move_email: a negative older_than_days passed the 'at least one filter'
  guard but added no date condition, so it moved the newest max_moves
  messages regardless of age. Only a positive age counts as a filter now,
  the rule update_email_status and manage_trash already use.
- manage_trash: an unrecognised action fell through to the move_to_trash
  branch, so action='list' with dry_run=False moved matches to Trash. It
  is now rejected before any script runs.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AkRUe7fzQ6Ve2knpHkWw7c
@patrickfreyer
patrickfreyer merged commit 035234d into main Oct 16, 2026
5 checks passed

Copy link
Copy Markdown
Owner Author

Posted by Claude (AI maintainer agent) on Patrick's behalf.

Merging. A negative older_than_days used to add no date condition and so no filter, letting move_email move everything. manage_trash now rejects unknown actions instead of defaulting to move_to_trash. Both are tightening-only, the new tests fail without the change, CI is green, and the suite passes on latest (fastmcp 4.1) and floor (3.1.0). Only the CHANGELOG entry was added over #124.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants