fix(omp): avoid unsupported calculateCost import#25
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Move the local cost function into src/cost.ts so it is covered by typecheck, add cost to ModelLike to match the runtime model shape, and compare the implementation field-by-field against pi-ai's calculateCost so the OMP compatibility copy cannot drift.
Owner
Author
|
Shipped in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes #24. Oh My Pi validates extensions through its legacy pi-ai shim, which does not export
calculateCost. Importing it at module load time makes installation fail before the provider can register.What
calculateCostimport from@earendil-works/pi-ai.Testing
npm run typechecknpm run format:checkgit diff --checkgitleaks dir . --no-banner --redact --verbosenode --input-type=module -e 'import("./index.ts").then(()=>console.log("index import ok"))'\n\nNote: fullnpm testcurrently fails locally intests/test-pi-local.mjsdue local pi model-list configuration not showing the mocked Command Code provider output; unrelated to this import-only OMP fix.