Repository navigation
Fix wired PDP Afterglow Wave not being detected - #379
Conversation
Bumps aurora so the vendored SDL treats 0e6f:018b as input-only over USB (patchzyy/aurora-wiicompiled#8).
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update submodule reference aurora-main |
The submodule reference changed to a new commit. |
Priority:
Estimated code review effort: 1 (Trivial) | ~2 minutes
Change: Bug fix · Severity of issue fixed: Medium
Possibly related issues
#377: The issue reports that a wired PDP Nintendo Switch controller is not detected. The supplied context says this submodule update fixes detection of the wired PDP Afterglow Wave over USB, which matches the reported problem; the issue is not confirmed closed.
Suggested reviewers: darthmdev, galaxisbeast
Merge Risk: 
Minimal · up to 747a9
-
No actionable merge-blocking issue is established for this submodule update. Merge readiness remains subject to normal build and controller compatibility checks.
Pre-merge checks: 
4
-
Full details: Linked Issues check
-
Explanation
Issue
#377requires detection of the wired PDP Nintendo Switch controller. The PR updates theaurora-mainsubmodule fromdfd2af2to33067e3. The PR description identifies this revision as the merged fix that supports device0e6f:018bwith SDL's input-only USB protocol. Issue#377defines no additional coding or automated-test requirement.
Full details: Out of Scope Changes check
-
Explanation
The whole-PR diff contains one change: the
aurora-mainsubmodule pointer. The change directly implements the controller-detection fix for issue#377. No unrelated source, test, or configuration changes are present.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Fixes #377.
Bumps aurora so the vendored SDL handles the wired PDP Afterglow Wave Controller for Switch (
0e6f:018b) with the input-only protocol over USB (patchzyy/aurora-wiicompiled#8).The pad broke in 0.9.0, when SDL went from 3.4.4 to 3.4.10. 3.4.10 lists
018bas a full Switch Pro controller because the wireless Wave uses that ID. The wired Wave doesn't answer the Pro USB handshake, so SDL fails to open it. HIDAPI has already claimed the device, so the other backends skip it too. The result is that the pad was missing from both the player list and "Unrecognized controllers". The fix backports upstream SDL c0efc5862c. Details and the before/after test are in the aurora PR.The submodule points at aurora
33067e3, the merge commit of patchzyy/aurora-wiicompiled#8.Summary by CodeRabbit