Skip to content

Fix wired PDP Afterglow Wave not being detected - #379

Merged
patchzyy merged 2 commits into
mainfrom
fix/issue-377-wired-switch-pad
Oct 29, 2026
Merged

patchzyy merged 2 commits into
mainfrom
fix/issue-377-wired-switch-pad

Conversation

@patchzyy

@patchzyy patchzyy commented Oct 29, 2026 •

Copy link
Copy Markdown
Owner

Fixes #377.

Bumps aurora so the vendored SDL handles the wired PDP Afterglow Wave Controller for Switch (0e6f:018b) with the input-only protocol over USB (patchzyy/aurora-wiicompiled#8).

The pad broke in 0.9.0, when SDL went from 3.4.4 to 3.4.10. 3.4.10 lists 018b as a full Switch Pro controller because the wireless Wave uses that ID. The wired Wave doesn't answer the Pro USB handshake, so SDL fails to open it. HIDAPI has already claimed the device, so the other backends skip it too. The result is that the pad was missing from both the player list and "Unrecognized controllers". The fix backports upstream SDL c0efc5862c. Details and the before/after test are in the aurora PR.

The submodule points at aurora 33067e3, the merge commit of patchzyy/aurora-wiicompiled#8.

Summary by CodeRabbit

  • Chores
    • Updated the application component to a newer revision. The available change details do not identify any user-visible features, fixes, or behavior changes. No changes to existing functionality are documented.

Bumps aurora so the vendored SDL treats 0e6f:018b as input-only over USB
(patchzyy/aurora-wiicompiled#8).
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fe404dc9-2f57-4182-8753-44018d635d3e
Commits

Reviewing files that changed from the base of the PR and between 570239e and 747a90a.

Files selected for processing: 1
  • aurora-main

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Walkthrough

The aurora-main submodule reference changed from commit dfd2af27f20d96ca281d39ed50630a6632955ee9 to 33067e34a17ca680eb961d9e0f3d48ddb22a7d7f.

Changes: Aurora submodule update

Layer / File(s) Summary
Update submodule reference
aurora-main
The submodule reference changed to a new commit.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix · Severity of issue fixed: Medium

Possibly related issues

  • #377: The issue reports that a wired PDP Nintendo Switch controller is not detected. The supplied context says this submodule update fixes detection of the wired PDP Afterglow Wave over USB, which matches the reported problem; the issue is not confirmed closed.

Suggested reviewers: darthmdev, galaxisbeast

Merge Risk: Minimal · up to 747a9

No actionable merge-blocking issue is established for this submodule update. Merge readiness remains subject to normal build and controller compatibility checks.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: fixing detection of the wired PDP Afterglow Wave controller.
Linked Issues check Passed Issue #377 requires detection of the wired PDP Nintendo Switch controller. The PR updates the aurora-main submodule from dfd2af2 to 33067e3. The PR description identifies this revision as the me…
Out of Scope Changes check Passed The whole-PR diff contains one change: the aurora-main submodule pointer. The change directly implements the controller-detection fix for issue #377. No unrelated source, test, or configuration chan…
Full details: Linked Issues check

Explanation

Issue #377 requires detection of the wired PDP Nintendo Switch controller. The PR updates the aurora-main submodule from dfd2af2 to 33067e3. The PR description identifies this revision as the merged fix that supports device 0e6f:018b with SDL's input-only USB protocol. Issue #377 defines no additional coding or automated-test requirement.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff contains one change: the aurora-main submodule pointer. The change directly implements the controller-detection fix for issue #377. No unrelated source, test, or configuration changes are present.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patchzyy
patchzyy merged commit eb99d86 into main Oct 29, 2026
7 checks passed
@patchzyy
patchzyy deleted the fix/issue-377-wired-switch-pad branch October 29, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Wired Switch Controller doesnt work anymore

1 participant