fix: zone grid snapping, shelf position panel, deselect on item placement#394
Merged
Conversation
…ment - Zone tool reads the editor's gridSnapStep (0.5/0.25/0.1/0.05) instead of a hardcoded 0.5 for both cursor move and click snapping. - Shelf inspector gains a Position group (vec3 X/Y/Z sliders), matching the item panel. - Item catalog clears the viewer selection before arming placement so shortcuts (rotate & co) don't hit both the ghost and the selected node. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
getDefaultLevelName / getLevelDisplayName ("Ground Floor" / "Floor N" /
"Basement N") lived in packages/editor's internal lib, so viewer-only
surfaces couldn't reach them and fell back to hand-rolled "Level N"
labels. The helpers are pure domain logic, so they move to core and
export from its barrel; the editor package's seven call sites now import
them from there.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Four small editor fixes:
0.5step for both cursor move and click; it now reads the editor'sgridSnapStepsetting (0.5 / 0.25 / 0.1 / 0.05) live, like the wall/column/shelf tools.Positiongroup with avec3field toshelfParametrics, rendered by the parametric inspector as three X/Y/Z sliders (same renderer the spawn node uses), matching the item panel.@pascal-app/core—getDefaultLevelName/getLevelDisplayName("Ground Floor" / "Floor N" / "Basement N") were internal topackages/editor, so viewer-only surfaces couldn't reach them and hand-rolled "Level N" labels instead. Pure domain logic → moved to core and exported from its barrel; the editor package's seven call sites import from there now.How to test
bun dev, open the editor.bun run buildconfirms the import move compiles across core/editor/nodes.Screenshots / screen recording
N/A — small interactive fixes; behavior is covered by the test steps above.
Checklist
bun dev(verified via typecheck +bun run build; needs a manual pass of the steps above)bun checkto verify)mainbranch