editor: fix preset double-commit ghosts, show compass in all view modes#393
Merged
Conversation
…k events A single physical click reaches commitAtCursor twice: node clicks are synthesized on pointerup (use-node-events) while grid:click rides the native click event from a canvas DOM listener (use-grid-events) that deliberately ignores stopPropagation. The second pass found the fresh draft already deleted and took the orphan re-create path, minting a hidden ghost copy, replaying the placement SFX, and abandoning the re-armed clone as a second ghost. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The floorplan compass now portals onto the always-visible viewer area instead of living inside the (display:none in 3D) floorplan pane. The 2D/3D navigation poses already sync through navigationSyncPose, so the needle and align-to-north stay correct in 2d, 3d, and split alike. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Two placement/navigation fixes:
MoveRegistryNodeTool.commitAtCursortwice: node clicks (slab:click, …) are synthesized on pointerup (use-node-events), whilegrid:clickrides the native click event from a canvas DOM listener (use-grid-events) that deliberately ignoresstopPropagation— and the tool's effect stays subscribed until React re-renders after the first commit exits move mode. The second pass found the fresh draft already deleted, took the orphan re-create path, and minted a permanent hidden ghost copy (plus a second placement SFX, plus abandoning the re-armed repeat-placement clone as another ghost). An early return on the existingcommittedflag stops the duplicate pass.display:nonein 3D. The 2D/3D navigation poses already sync throughnavigationSyncPose, so the needle tracks the 3D camera and align-to-north rotates it — no behavior rewrite needed.How to test
bun dev, open a project with a room (floor slab), and click a shelf preset in the catalog to arm placement.Screenshots / screen recording
N/A — will add a quick clip if helpful; behavior is easiest to verify with the steps above (listen for the single SFX, watch the scene graph).
Checklist
bun dev(verified via typecheck + lint; runtime pass pending)bun checkto verify)mainbranch🤖 Generated with Claude Code