fix: guard WallTool grid handlers against null wallPreviewRef#392
Closed
anton-pascal wants to merge 1 commit into
Closed
fix: guard WallTool grid handlers against null wallPreviewRef#392anton-pascal wants to merge 1 commit into
anton-pascal wants to merge 1 commit into
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Contributor
Author
|
Heads-up for review: this PR overlaps with #371 — both guard |
This was referenced Jun 10, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sentry: MONOREPO-EDITOR-BE (issue 7494188332)
TypeError: Cannot set properties of null (setting 'visible')inWallTool.Root cause
onGridClickis subscribed to the mittgrid:clickevent. When the user switches tools mid-draft, theWallToolpreview<mesh>unmounts andwallPreviewRef.currentbecomes null — but a queuedgrid:clickevent can still fire before the effect cleanup runsemitter.off. The state-1 branch then writeswallPreviewRef.current.visible = falseon a null ref and throws.Fix
Add
if (!wallPreviewRef.current) returnat the top ofonGridClick, mirroring the guardonGridMovealready has (if (!(cursorRef.current && wallPreviewRef.current)) return).stopDraftingalready null-guards itswallPreviewRef.current.visiblewrite (it's also called fromonCancel), so no change needed there.curve-tool.tsxwas checked for the same pattern — itsonGridClickdoesn't touch a preview mesh ref, so no change needed.Typecheck (
tsc --buildinpackages/nodes): ✅ passes.Precedent: same class of fix as "fix: guard onShelfMove against null cursorGroupRef (Sentry EDITOR-BC)".