refactor: classify isotype before EU-numbered Fc allotype detection - #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 요약
constant-domain 분석 순서를 다음과 같이 명확하게 분리했습니다.
eu_position을 canonical 좌표로 사용해 query 위치를 찾습니다. Fc(CH2/CH3)의 G1m/G2m/G3m/G4m marker도 더 이상 rawsubclass_offset으로 직접 찾지 않습니다.주요 구현
src/abcat/cdomain.pymatched_residues는EU_214,EU_356같은 canonical 좌표를 사용subclass_offset은 allotype lookup에서 사용하지 않음absent와 구분해inconclusive반환tests/test_cdomain_eu.pysubclass_offset를 제거해도 EU position만으로 G1m17이 올바르게 검출되는지 검증기존 G1m17/G1m1 및 engineered antibody 테스트와 호환되도록 기존 marker 데이터 형식은 유지했습니다.