Block libvips untrusted operations for image uploads - #141
Draft
parterburn wants to merge 1 commit into
Draft
Conversation
Dabble Me feeds untrusted photos through CarrierWave::Vips and collage generation. Disable libvips unfuzzed operations at boot so Magick/SVG/PDF and similar loaders cannot run, while keeping JPEG/PNG/GIF/WebP/HEIC. Co-authored-by: Paul Arterburn <parterburn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defense-in-depth for Dabble Me’s libvips image pipeline (CarrierWave::Vips, collages, MCP/
ImageProcessing::Vips).CVE-2026-66066 targets Active Storage variant processing. Dabble Me does not use Active Storage for uploads, so that advisory’s Rails bump does not apply. We still process untrusted user images with the same underlying libvips surface, and nothing was calling
Vips.block_untrusted(true).Changes
config/initializers/vips.rbto disable unfuzzed/untrusted libvips loaders and savers at boot (web + Sidekiq).libvips≥ 8.13,ruby-vips≥ 2.2.1).Expected impact
Test plan
bundle exec rspec spec/initializers/vips_spec.rb(+ collage/uploader specs) — 11 examples, 0 failures