Upgrade Rails to 7.1 and localize legacy Bootstrap assets - #106
Draft
parterburn wants to merge 5 commits into
Draft
Upgrade Rails to 7.1 and localize legacy Bootstrap assets#106parterburn wants to merge 5 commits into
parterburn wants to merge 5 commits into
Conversation
Co-authored-by: Paul Arterburn <parterburn@users.noreply.github.com>
Co-authored-by: Paul Arterburn <parterburn@users.noreply.github.com>
Co-authored-by: Paul Arterburn <parterburn@users.noreply.github.com>
Co-authored-by: Paul Arterburn <parterburn@users.noreply.github.com>
Co-authored-by: Paul Arterburn <parterburn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config.load_defaults 6.1behavior for a smaller runtime shifttwbs_sass_railsdependency by vendoring its Bootstrap 3 / Font Awesome asset tree intovendor/assetssass-railstosassc-railsand add the explicitrespond.jsmanifest link required by the newer Sprockets behaviordatabase_cleaner-active_recordApplicationController#redirect_back_or_toto match the Rails 7 helper signature used by Devise account updatesTesting
bundle exec rails runner "puts \"rails=#{Rails.version}\"; puts \"rack=#{Rack.release}\"; puts \"env=#{Rails.env}\""SECRET_KEY_BASE_DUMMY=1 RAILS_ENV=production bundle exec rails assets:precompilebundle audit check --updatebundle exec rspec spec/controllers/registrations_controller_spec.rb:19 spec/controllers/registrations_controller_spec.rb:26bundle exec rspec spec/controllers/welcome_controller_spec.rb spec/features/welcome_spec.rbbundle exec rspec spec/controllers/registrations_controller_spec.rb:117 spec/controllers/registrations_controller_spec.rb:130 spec/controllers/registrations_controller_spec.rb:143 spec/controllers/registrations_controller_spec.rb:155/and/settings/u7vtaqn27izeyvo6999Follow-ups
Rails.application.secrets, mailer preview path configuration, cache format version, and some test-only configurationdb/schema.rbchanges remain outside this PR