Skip to content

fix: create checksum#1701

Merged
nitisht merged 1 commit into
parseablehq:mainfrom
nikhilsinhaparseable:fix/checksum
Jun 24, 2026
Merged

fix: create checksum#1701
nitisht merged 1 commit into
parseablehq:mainfrom
nikhilsinhaparseable:fix/checksum

Conversation

@nikhilsinhaparseable

@nikhilsinhaparseable nikhilsinhaparseable commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

error log says -

2026-06-24T02:51:44.6764789Z Found 9 artifact(s)
2026-06-24T02:51:44.6766835Z No input name or pattern filtered specified, downloading all artifacts
2026-06-24T02:51:44.6768784Z An extra directory with the artifact name will be created for each download
2026-06-24T02:51:44.6771068Z Preparing to download the following artifacts:
2026-06-24T02:51:44.6772592Z - Parseable_OSS_x86_64-pc-windows-msvc.exe (ID: 7829062620, Size: 63567218)
2026-06-24T02:51:44.6774399Z - parseablehq~parseable~P3HWJ4.dockerbuild (ID: 7826604239, Size: 143859)
2026-06-24T02:51:44.6776158Z - parseablehq~parseable~ZRSGVU.dockerbuild (ID: 7826603492, Size: 80459)
2026-06-24T02:51:44.6777980Z - parseablehq~parseable~H1S8EH.dockerbuild (ID: 7826602840, Size: 82911)
2026-06-24T02:51:44.6780110Z - Parseable_OSS_aarch64-apple-darwin-kafka (ID: 7824801136, Size: 61255282)
2026-06-24T02:51:44.6781982Z - Parseable_OSS_x86_64-unknown-linux-gnu-kafka (ID: 7824782933, Size: 67270299)
2026-06-24T02:51:44.6783825Z - Parseable_OSS_x86_64-unknown-linux-gnu (ID: 7824392475, Size: 63793893)
2026-06-24T02:51:44.6785564Z - Parseable_OSS_aarch64-apple-darwin (ID: 7824174867, Size: 58240501)
2026-06-24T02:51:44.6787349Z - Parseable_OSS_aarch64-unknown-linux-gnu (ID: 7823892564, Size: 62219518)
2026-06-24T02:51:48.3033121Z Artifact download completed successfully.
2026-06-24T02:51:48.4990067Z Artifact download completed successfully.
2026-06-24T02:51:48.5846263Z Artifact download completed successfully.
2026-06-24T02:51:48.6834852Z Artifact download completed successfully.
2026-06-24T02:51:48.7339086Z Artifact download completed successfully.
2026-06-24T02:51:48.7879220Z Artifact download completed successfully.
2026-06-24T02:52:10.2001073Z ##[error]Unable to download artifact(s): Unable to download and extract artifact: Artifact download failed after 5 retries.

the download artifact step is failing to download the .dockerbuild file which gets created by the softprops/action-gh-release but create checksum step should look at Parseable_OSS binaries only

fix is to add a filter to download only Parseable_OSS_* files and skip other intermediate files like *.dockerbuild
because dockerbuild files download should not fail checksum job

Summary by CodeRabbit

  • Chores
    • Refined release workflow artifact handling for improved checksum generation accuracy.

error log says -
```
2026-06-24T02:51:44.6764789Z Found 9 artifact(s)
2026-06-24T02:51:44.6766835Z No input name or pattern filtered specified, downloading all artifacts
2026-06-24T02:51:44.6768784Z An extra directory with the artifact name will be created for each download
2026-06-24T02:51:44.6771068Z Preparing to download the following artifacts:
2026-06-24T02:51:44.6772592Z - Parseable_OSS_x86_64-pc-windows-msvc.exe (ID: 7829062620, Size: 63567218)
2026-06-24T02:51:44.6774399Z - parseablehq~parseable~P3HWJ4.dockerbuild (ID: 7826604239, Size: 143859)
2026-06-24T02:51:44.6776158Z - parseablehq~parseable~ZRSGVU.dockerbuild (ID: 7826603492, Size: 80459)
2026-06-24T02:51:44.6777980Z - parseablehq~parseable~H1S8EH.dockerbuild (ID: 7826602840, Size: 82911)
2026-06-24T02:51:44.6780110Z - Parseable_OSS_aarch64-apple-darwin-kafka (ID: 7824801136, Size: 61255282)
2026-06-24T02:51:44.6781982Z - Parseable_OSS_x86_64-unknown-linux-gnu-kafka (ID: 7824782933, Size: 67270299)
2026-06-24T02:51:44.6783825Z - Parseable_OSS_x86_64-unknown-linux-gnu (ID: 7824392475, Size: 63793893)
2026-06-24T02:51:44.6785564Z - Parseable_OSS_aarch64-apple-darwin (ID: 7824174867, Size: 58240501)
2026-06-24T02:51:44.6787349Z - Parseable_OSS_aarch64-unknown-linux-gnu (ID: 7823892564, Size: 62219518)
2026-06-24T02:51:48.3033121Z Artifact download completed successfully.
2026-06-24T02:51:48.4990067Z Artifact download completed successfully.
2026-06-24T02:51:48.5846263Z Artifact download completed successfully.
2026-06-24T02:51:48.6834852Z Artifact download completed successfully.
2026-06-24T02:51:48.7339086Z Artifact download completed successfully.
2026-06-24T02:51:48.7879220Z Artifact download completed successfully.
2026-06-24T02:52:10.2001073Z ##[error]Unable to download artifact(s): Unable to download and extract artifact: Artifact download failed after 5 retries.
```

the download artifact step is failing to download the *.dockerbuild file
which gets created by the softprops/action-gh-release
but create checksum step should look at Parseable_OSS* binaries only

fix is to add a filter to download only Parseable_OSS_* files and
skip other intermediate files like *.dockerbuild
because dockerbuild files download should not fail checksum job
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: d2cc51a0-22f8-4312-8ac6-7b2950965284

📥 Commits

Reviewing files that changed from the base of the PR and between 1998658 and c995422.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

Walkthrough

The create-checksum job in the release workflow adds a pattern: Parseable_OSS_* filter to the actions/download-artifact@v4.1.7 step, restricting artifact downloads to only those whose names match that glob pattern.

Changes

Release Workflow Artifact Filter

Layer / File(s) Summary
Add pattern filter to download-artifact step
.github/workflows/release.yml
The create-checksum job's artifact download step now includes pattern: Parseable_OSS_*, scoping downloads to only artifacts matching that name prefix.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops through artifacts galore,
But now we only fetch what starts with OSS_*,
No stray bits to clutter the checksum floor,
The pattern is set, nothing more, nothing less!
🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix: create checksum' is vague and overly generic; it fails to clearly explain that the fix addresses a download filter pattern for artifacts. Enhance the title to be more specific, such as 'fix: add pattern filter to artifact download in checksum job' to clarify the actual change being made.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The PR description clearly explains the problem, the root cause, and the solution, but does not include the template's testing and documentation checkboxes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@nitisht nitisht self-requested a review June 24, 2026 08:49
@nitisht nitisht merged commit e178599 into parseablehq:main Jun 24, 2026
12 checks passed
parmesant pushed a commit to parmesant/parseable that referenced this pull request Jun 24, 2026
the download artifacts should look at Parseable_OSS* binaries only
so adding a filter to download only Parseable_OSS_* files and
skip other intermediate files like *.dockerbuild
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants