Implement ext_trie_verify_proof and fix ext_transaction_index param types#2272
Closed
rockbmb wants to merge 1 commit into
Closed
Implement ext_trie_verify_proof and fix ext_transaction_index param types#2272rockbmb wants to merge 1 commit into
ext_trie_verify_proof and fix ext_transaction_index param types#2272rockbmb wants to merge 1 commit into
Conversation
|
User @sisyphus-dev-ai, please sign the CLA here. |
rockbmb
changed the title
ext_trie_verify_proof and fix ext_transaction_index param types
rockbmb
force-pushed
the
bulletin-chain-support
branch
from
May 29, 2026 02:14
1e050fe to
88c98a2
Compare
…dex param types Implement ext_trie_keccak_256_verify_proof_version_1 and _version_2 using proof_decode, matching the blake2 variants from paritytech#2221. Fix ext_transaction_index_index_version_1 and ext_transaction_index_renew_version_1: both used expect_pointer_size_raw (expects i64) but the actual signatures are (i32, i32, i32) and (i32, i32). The type mismatch hit unreachable!() on any runtime that indexes transactions.
rockbmb
force-pushed
the
bulletin-chain-support
branch
from
May 29, 2026 02:17
88c98a2 to
0ae463c
Compare
Author
|
Opened on the wrong repo — smoldot-archive is a redirect from smol-dot/smoldot. Reopening on paritytech/smoldot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement ext_trie_blake2_256_verify_proof (v1, v2) and ext_trie_keccak_256_verify_proof (v1, v2) using the existing
trie::proof_decode. These were stubbed withhost_fn_not_implemented!(), causing panics on runtimes that verify Merkle proofs (e.g. Polkadot Bulletin'spallet-transaction-storage).Fix
ext_transaction_index_index_version_1andext_transaction_index_renew_version_1: both usedexpect_pointer_size_raw!(expects i64) but the actual signatures are(i32, i32, i32)and(i32, i32). The type mismatch hitsunreachable!()on any runtime that indexes transactions.