Cleanup Github workflows and Dockerfiles#90
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up CI workflows and Dockerfiles by removing broken configurations and standardizing the build process. It addresses compilation failures caused by non-existent cargo features and missing build artifacts.
- Removed broken Docker build jobs for non-existent features (
tick,versi-tick,versi-relay,rococo) - Consolidated CI to two working jobs:
stps-funderandstps-sender - Updated Dockerfiles to use latest Ubuntu and fix build paths
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/build-images-pr.yml |
Removed entire workflow file for non-existent branch |
.github/workflows/build-images.yml |
Removed broken jobs and updated tags for remaining jobs |
utils/dockerfiles/Dockerfile.tps |
Removed entire Dockerfile |
utils/dockerfiles/Dockerfile.sender-any |
Removed entire Dockerfile |
utils/dockerfiles/Dockerfile.sender |
Updated to use workspace build and latest Ubuntu |
utils/dockerfiles/Dockerfile.funder |
Updated to use workspace build and latest Ubuntu |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| run: | | ||
| echo "New image has been pushed to ${{ steps.push-to-dockerhub.outputs.registry-path }}" | ||
|
|
||
| tps-tick: |
There was a problem hiding this comment.
So now, we can basically use sender/funder and the previous images are not needed ?
There was a problem hiding this comment.
Right, so in 700b4d8 the repo was significantly changed, and all the feature-flags got removed, however, the Github workflow pipeline were not updated, nor the Dockerfile.
So this PR (tries to) sync the Dockerfiles and Github workflow pipeline with the code base.
| @@ -15,7 +15,7 @@ jobs: | |||
| uses: redhat-actions/buildah-build@v2 | |||
There was a problem hiding this comment.
We should use commits instead of tags here, for security reasons.
There was a problem hiding this comment.
Agreed! Can you provide me with some appropriate tags commit hashes? :)
Co-authored-by: Javier Viola <363911+pepoviola@users.noreply.github.com>
|
@pepoviola CD failed when we merged this, see https://github.com/paritytech/polkadot-stps/actions/runs/18002958206/job/51216412992 we seem to have permission issues? can you help us with that? :) |
|
@Sajjon I'm checking the dockerhub settings |
|
@Sajjon I fixed the permissions. The docker hub repo seemed abandoned to me (latest image push was 2 years ago) so I removed credentials. Now I put them back and the pipeline works: https://github.com/paritytech/polkadot-stps/actions/runs/18002958206 |
|
Thanks for fix the permissions @alvicsam 🚀 . |
Tip
I've locally built the
senderbinary using docker, and ran the container locally using docker and it spams transactionssuccessfully, see e.g. this block with lots of transactions
Fix issues with CI, see failing recent jobs, issues:
tick,versi-tick,versi-relaynorrococoError: building at STEP "COPY --from=builder /build/utils/funder/target/release/funder /usr/local/bin": checking on sources under "/home/runner/.local/share/containers/storage/overlay/6d09ccf8d236e9aefb6e662b7b49233d9e3fd68d5e3ef3e7fcc47cb7379452ba/merged": copier: stat: "/build/utils/funder/target/release/funder": no such file or directorySeveral improvements, bug fixes and clean up regarding CI/CD (Github workflow) and Dockerfile contents:
.github/workflows/build-images-pr.ymlsince it was being triggered by pushes to a branch which does not even exist (s0me0ne/overhaul)tps-tick,sender-versi-tick,sender-versi-relay,tps-versi-relay, tps-versi-tick,sender-rococo,tps-rococo`, these all references cargo feature flags which does not exist.stps-funderandstps-sender, using the Dockerfilesutils/dockerfiles/Dockerfile.funderandutils/dockerfiles/Dockerfile.senderrespectively, which has been updated too:utils/dockerfiles/Dockerfile.sender-any(renamed toutils/dockerfiles/Dockerfile.sender) to use latest Ubuntu and fix compilation warningsutils/dockerfiles/Dockerfile.funderto use latest Ubuntu and fix compilation warnings