[pallet-conviction-voting] Prevent and remove empty storage entries by Nathy-bajo · Pull Request #7631 · paritytech/polkadot-sdk

Nathy-bajo · 2025-02-19T16:16:54Z

resolves #7458

The conviction-voting pallet was creating and retaining 29,000+ empty storage entries (VotingFor and ClassLocksFor with zero votes, delegations, and locks) which this PR fixes by implementing automatic cleanup after vote/delegation operations, a one-time migration to remove existing empty entries, and a new permissionless extrinsic for manual cleanup—all without breaking changes.

Polkadot address: 121HJWZtD13GJQPD82oEj3gSeHqsRYm1mFgRALu4L96kfPD1

Nathy-bajo · 2025-02-19T16:29:39Z

Please review @muharem

Nathy-bajo · 2026-01-19T07:45:18Z

Please review @ggwpez @muharem
Apologies for the delay!

muharem

do we still let zero balance vote? I do not see the restriction on this regard

Nathy-bajo · 2026-03-19T12:35:27Z

do we still let zero balance vote? I do not see the restriction on this regard

I have updated it

Nathy-bajo · 2026-04-12T18:32:17Z

/cmd prdoc --audience runtime_dev --bump minor

Nathy-bajo · 2026-04-14T22:41:34Z

Ready for review @muharem @ggwpez

Nathy-bajo · 2026-04-20T19:20:47Z

/cmd label T1-FRAME

…time_dev --bump minor'

Nathy-bajo · 2026-07-01T17:03:13Z

@muharem All reviews addressed, please take a look!

Co-authored-by: Dhiraj Sah <dhiraj@parity.io>

dhirajs0 · 2026-07-17T13:46:51Z

+				}
+			});
+
+			ensure!(voting_cleaned || locks_cleaned, Error::<T, I>::NotVoter);


On a no-op cleanup this returns NotVoter, but the caller isn't expected to be a voter and the target may simply have nothing stale. Overloading NotVoter makes error handling ambiguous. Consider a dedicated variant, e.g. add NothingToClean and use it here:

ensure!(voting_cleaned || locks_cleaned, Error::<T, I>::NothingToClean);

Done, added NothingToClean and used it for the no-op case.

dhirajs0 · 2026-07-17T14:46:16Z

/cmd bench --pallet pallet_conviction_voting

github-actions · 2026-07-17T14:47:03Z

Command "bench --pallet pallet_conviction_voting" has started 🚀 See logs here

…t_conviction_voting'

github-actions · 2026-07-17T23:04:52Z

Command "bench --pallet pallet_conviction_voting" has finished ✅ See logs here

Details

Subweight results:

File	Extrinsic	Old	New	Change [%]
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_conviction_voting.rs	remove_other_vote	260.52us	282.11us	+8.29
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_conviction_voting.rs	vote_new	4.94ms	5.30ms	+7.14
substrate/frame/staking-async/runtimes/rc/src/weights/pallet_conviction_voting.rs	cleanup_empty_storage		517.20us	Added
substrate/frame/staking-async/runtimes/parachain/src/weights/pallet_conviction_voting.rs	cleanup_empty_storage		517.20us	Added
substrate/frame/conviction-voting/src/weights.rs	cleanup_empty_storage		517.20us	Added
polkadot/runtime/rococo/src/weights/pallet_conviction_voting.rs	cleanup_empty_storage		517.20us	Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_conviction_voting.rs	cleanup_empty_storage		293.59us	Added

Command output:

❌ Failed benchmarks of runtimes/pallets:
-- dev: ['pallet_conviction_voting']
✅ Successful benchmarks of runtimes/pallets:
-- asset-hub-westend: ['pallet_conviction_voting']

Nathy-bajo requested a review from a team as a code owner February 19, 2025 16:16

Nathy-bajo marked this pull request as draft February 19, 2025 16:17

muharem reviewed Mar 31, 2025

View reviewed changes

Comment thread substrate/frame/conviction-voting/src/lib.rs Outdated

muharem reviewed Mar 31, 2025

View reviewed changes

Comment thread substrate/frame/conviction-voting/src/lib.rs Outdated

muharem reviewed Mar 31, 2025

View reviewed changes

Comment thread substrate/frame/conviction-voting/src/migrations.rs Outdated

muharem reviewed Mar 31, 2025

View reviewed changes

Comment thread substrate/frame/conviction-voting/src/migrations.rs Outdated

ggwpez reviewed Mar 31, 2025

View reviewed changes

Comment thread substrate/frame/conviction-voting/src/migrations.rs Outdated

muharem reviewed Mar 31, 2025

View reviewed changes

Comment thread substrate/frame/conviction-voting/src/lib.rs Outdated

Nathy-bajo force-pushed the pallet-conviction-voting branch from 224df7d to 8908678 Compare January 19, 2026 07:43

Nathy-bajo marked this pull request as ready for review January 19, 2026 07:44

Nathy-bajo requested review from ggwpez and muharem January 19, 2026 07:44

Nathy-bajo changed the title ~~[pallet-conviction-voting] prevent creation of zero-balance records #7458~~ [pallet-conviction-voting] Prevent and remove empty storage entries Jan 19, 2026

muharem reviewed Mar 4, 2026

View reviewed changes

Comment thread substrate/frame/conviction-voting/src/migrations.rs Outdated

muharem reviewed Mar 4, 2026

View reviewed changes

Comment thread substrate/frame/conviction-voting/src/lib.rs Outdated

muharem reviewed Mar 4, 2026

View reviewed changes

pgherveou added this to [preview] release tracker Mar 18, 2026

github-project-automation Bot moved this to Todo in [preview] release tracker Mar 18, 2026

pgherveou removed this from [preview] release tracker Mar 19, 2026

Nathy-bajo requested a review from muharem March 19, 2026 12:35

paritytech-cmd-bot-polkadot-sdk Bot added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Apr 20, 2026

muharem mentioned this pull request Jun 28, 2026

try state check for pallet conviction voting #12418

Open

muharem reviewed Jun 30, 2026

View reviewed changes

prevent and remove empty storage entries

6f542e9

Nathy-bajo and others added 6 commits July 1, 2026 15:19

update weights

4a24981

fix umbrella crate error

8131c8a

remove migrations

da5255c

resolve conflicts

08d9437

Update from github-actions[bot] running command 'prdoc --audience run…

09df045

…time_dev --bump minor'

Add benchmark

033a2d2

Nathy-bajo force-pushed the pallet-conviction-voting branch from 36c1909 to 033a2d2 Compare July 1, 2026 15:58

Nathy-bajo requested a review from muharem July 1, 2026 17:03

Merge branch 'master' into pallet-conviction-voting

cab8204

muharem reviewed Jul 14, 2026

View reviewed changes

Comment thread substrate/frame/conviction-voting/src/benchmarking.rs

muharem requested a review from dhirajs0 July 14, 2026 15:05

muharem reviewed Jul 14, 2026

View reviewed changes

Comment thread substrate/frame/conviction-voting/src/lib.rs Outdated

muharem reviewed Jul 14, 2026

View reviewed changes

Comment thread polkadot/runtime/westend/src/weights/pallet_conviction_voting.rs Outdated

final nits

c8e5636

bkchr reviewed Jul 14, 2026

View reviewed changes

Comment thread substrate/frame/conviction-voting/src/lib.rs Outdated

Nathy-bajo and others added 2 commits July 15, 2026 07:35

smol nits

84675e6

Merge branch 'master' into pallet-conviction-voting

2c424d7

dhirajs0 reviewed Jul 15, 2026

View reviewed changes

Comment thread substrate/frame/conviction-voting/src/lib.rs Outdated

Nathy-bajo and others added 2 commits July 15, 2026 19:33

Update substrate/frame/conviction-voting/src/lib.rs

4408a08

Co-authored-by: Dhiraj Sah <dhiraj@parity.io>

Merge branch 'master' into pallet-conviction-voting

c879a66

dhirajs0 reviewed Jul 17, 2026

View reviewed changes

Nathy-bajo and others added 3 commits July 17, 2026 19:21

clean delegation targets and clarify cleanup errors

82e21be

format pallet-conviction

605677d

Update from github-actions[bot] running command 'bench --pallet palle…

7ab1e19

…t_conviction_voting'

fix ci check-semver error

4336107

Nathy-bajo requested a review from dhirajs0 July 19, 2026 09:09

Uh oh!

Conversation

Nathy-bajo commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nathy-bajo commented Feb 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nathy-bajo commented Jan 19, 2026

Uh oh!

Uh oh!

Uh oh!

muharem left a comment

Choose a reason for hiding this comment

Uh oh!

Nathy-bajo commented Mar 19, 2026

Uh oh!

Nathy-bajo commented Apr 12, 2026

Uh oh!

Nathy-bajo commented Apr 14, 2026

Uh oh!

Nathy-bajo commented Apr 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nathy-bajo commented Jul 1, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dhirajs0 Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

Nathy-bajo Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

dhirajs0 commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Nathy-bajo commented Feb 19, 2025 •

edited

Loading