[WIP] pallet-revive: cold/hot storage access pricing for call opcodes#12673
Open
marian-radu wants to merge 6 commits into
Open
[WIP] pallet-revive: cold/hot storage access pricing for call opcodes#12673marian-radu wants to merge 6 commits into
marian-radu wants to merge 6 commits into
Conversation
Contributor
Author
|
/cmd bench --runtime asset-hub-westend dev --pallet pallet_revive --clean |
Contributor
|
Command "bench --runtime asset-hub-westend dev --pallet pallet_revive --clean" has started 🚀 See logs here |
…t-hub-westend dev --pallet pallet_revive --clean'
Contributor
|
Command "bench --runtime asset-hub-westend dev --pallet pallet_revive --clean" has finished ✅ See logs here DetailsSubweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the per-transaction cold/hot pricing from #12104 to the storage reads performed by the call opcodes in pallet-revive. The first access to each storage item within a transaction is billed "cold"; any later access to the same item is "hot".
Description
Covered operations
Cold/hot storage access pricing now also applies to:
CALL/STATICCALL/DELEGATECALLopcodes,Access entries
The access list tracks one entry per storage item, so each opcode is priced by exactly what it reads: