statement-store: configurable per-category limits#12667
Draft
s0me0ne-unkn0wn wants to merge 1 commit into
Draft
Conversation
Closes #11936. The store capacity is now partitioned into per-category buckets, one for each reason a statement may be kept (explicit affinity, DHT affinity, pending gossip), with individually configurable limits, so that traffic stored for one reason cannot crowd out traffic stored for another. Statements are submitted with a category mask via the new StatementStore::submit_with_category_mask method. The store picks the highest-priority bucket in the mask with free capacity (explicit > DHT > pending), falling through the mask as buckets fill up. When every bucket in the mask is full, the statement may borrow free space from a higher-priority bucket; borrowed space is reclaimed first when native statements need the bucket. Buckets without dedicated limits configured are bounded only by the global store limits, keeping the default behavior unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JFFpAKHKJjgydHbEzys3N8 Signed-off-by: Dmitry Sinyavin <dmitry.sinyavin@parity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11936.
The store capacity is partitioned into per-category buckets, one for each reason a statement may be kept (explicit affinity, DHT affinity, pending gossip), with individually configurable limits, so that traffic stored for one reason cannot crowd out traffic stored for another.
Statements are submitted with a category mask via the new
StatementStore::submit_with_category_mask method. The store picks the highest-priority bucket in the mask with free capacity (explicit > DHT > pending), falling through the mask as buckets fill up. When every bucket in the mask is full, the statement may borrow free space from a higher-priority bucket; borrowed space is reclaimed first when native statements need the bucket.Buckets without dedicated limits configured are bounded only by the global store limits, keeping the default behavior unchanged.