[pallet-revive] Reject re-entrant CREATE2 at an in-construction address#12645
Open
Nathy-bajo wants to merge 2 commits into
Open
[pallet-revive] Reject re-entrant CREATE2 at an in-construction address#12645Nathy-bajo wants to merge 2 commits into
Nathy-bajo wants to merge 2 commits into
Conversation
Contributor
Author
|
/cmd label T7-smart_contracts |
paritytech-cmd-bot-polkadot-sdk
Bot
added
the
T7-smart_contracts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12639 by rejecting a nested instantiate whose target address is already being constructed by an ancestor frame, closing the re-entrant
CREATE2collision that let two constructors run for one account and permanently leaked its consumer/refcount and storage deposit.