Skip to content

Remove deprecated build-spec CLI subcommand#12586

Open
Kanasjnr wants to merge 17 commits into
paritytech:masterfrom
Kanasjnr:kanas/remove-build-spec
Open

Remove deprecated build-spec CLI subcommand#12586
Kanasjnr wants to merge 17 commits into
paritytech:masterfrom
Kanasjnr:kanas/remove-build-spec

Conversation

@Kanasjnr

@Kanasjnr Kanasjnr commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Remove the deprecated build-spec CLI subcommand and BuildSpecCmd from sc-cli.
  • Migrate all callers (nodes, templates, scripts, docs, zombienet) to export-chain-spec.

Part of #11561

@Kanasjnr
Remove deprecated build-spec CLI subcommand.
77f431b 
Migrate callers to export-chain-spec and drop BuildSpecCmd from sc-cli.
@Kanasjnr
Kanasjnr requested review from a team as code owners July 7, 2026 14:38
@Kanasjnr

Kanasjnr commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/cmd prdoc --audience node_dev --bump major

@Kanasjnr

Kanasjnr commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/cmd label T13-deprecation

@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk Bot added the T13-deprecation The current issue/pr is, or should be, part of a deprecation process. label Jul 7, 2026
@franciscoaguirre

franciscoaguirre commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@Kanasjnr Check out the CI jobs, they are failing because you removed build-spec. Make sure all references to it are removed.

@Kanasjnr

Kanasjnr commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@Kanasjnr Check out the CI jobs, they are failing because you removed build-spec. Make sure all references to it are removed.

I was waiting on @bkontur regarding the CI is failing on zombienet tests because zombienet-orchestrator 0.4.9 still defaults to build-spec for chain spec generation. After removing the subcommand, tests like sync_blocks_from_tip_without_connected_collator and minimal_template_block_production_test fail with unrecognized subcommand 'build-spec'.

Options I was thinking was
Maybe to Defer this PR until zombienet-orchestrator switches its default to export-chain-spec or Override with_chain_spec_command across the zombienet test files in this PR

franciscoaguirre
franciscoaguirre approved these changes Jul 9, 2026
View reviewed changes
Comment thread cumulus/test/service/src/cli.rs Outdated
Comment thread prdoc/pr_12586.prdoc Outdated
Comment thread templates/minimal/node/src/cli.rs Outdated
Comment thread templates/solochain/node/src/cli.rs Outdated
bkontur and others added 7 commits July 10, 2026 11:58
@bkontur @franciscoaguirre
Apply suggestions from code review
c060559 
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
@bkontur
Merge branch 'master' into kanas/remove-build-spec
571093c
@Kanasjnr
Migrate zombienet tests from build-spec to export-chain-spec.
1c5ac96 
Override zombienet chain spec generation in relay and parachain network
builders so tests work after removing the build-spec CLI subcommand.
@Kanasjnr
Wrap long with_chain_spec_command lines for rustfmt.
924575d
@Kanasjnr
Map export-chain-spec default chain id for test-parachain.
44c7da2 
When zombienet omits --chain, ExportChainSpecCmd defaults to "local",
but test-parachain's embedded default uses the empty id (as build-spec did).
@Kanasjnr
Drop --raw from zombienet export-chain-spec commands.
590fa1f 
Zombienet must export a plain chain-spec first so it can customize
genesis (para registration, overrides) before converting to raw.
Passing --raw up front skipped that step and left paras unregistered.
@Kanasjnr
Fix remaining zombienet export-chain-spec CI failures.
3d529bf 
Map omni-node's default "local" chain id to the empty default used by
build-spec, and restore --raw for the substrate-only block_building test.
bkchr
bkchr requested changes Jul 12, 2026
View reviewed changes
Comment thread cumulus/zombienet/zombienet-sdk/tests/zombie_ci/block_bundling/warp_sync.rs
Comment thread cumulus/test/service/src/main.rs Outdated
@Kanasjnr
Default export-chain-spec --chain to empty id.
826e2a2 
Match SharedParams/build-spec when --chain is omitted, and drop the
temporary local→empty remaps in test-parachain and omni-node.
@Kanasjnr Kanasjnr mentioned this pull request Jul 12, 2026
Open
2 tasks
@Kanasjnr

Kanasjnr commented Jul 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

ExportChainSpec default chain id fixed in 826e2a2: --chain now defaults to "" (same as old SharedParams / build-spec), and the temporary local→"" remaps in test-parachain / omni-node were removed.

Per-test with_chain_spec_command(... export-chain-spec ...) overrides these are only needed because zombienet-sdk still defaults to build-spec. Opened a fix upstream: paritytech/zombienet-sdk#557

Once that lands and is released, i can bump the zombienet deps here and delete the per-test overrides @bkchr

@Kanasjnr
Kanasjnr requested a review from bkchr July 12, 2026 21:16
@Kanasjnr

Kanasjnr commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

@bkontur 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes
@xermicus xermicus xermicus approved these changes
@bkchr bkchr Awaiting requested review from bkchr

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

T13-deprecation The current issue/pr is, or should be, part of a deprecation process.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Kanasjnr @franciscoaguirre @bkchr @xermicus @bkontur