Permissionless Authorized Dispatch for pallet-whitelist#12452
Open
PSYKYODAI wants to merge 9 commits into
Open
Permissionless Authorized Dispatch for pallet-whitelist#12452PSYKYODAI wants to merge 9 commits into
pallet-whitelist#12452PSYKYODAI wants to merge 9 commits into
Conversation
PSYKYODAI
marked this pull request as ready for review
July 3, 2026 00:33
Contributor
|
@PSYKYODAI marge master please. there is some major changes merged to the pallet #11336 |
Contributor
Author
|
/cmd label T2-pallets |
paritytech-cmd-bot-polkadot-sdk
Bot
added
the
T2-pallets
Contributor
Author
|
Master has been merged @muharem |
bkontur
reviewed
Jul 17, 2026
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
bkontur
reviewed
Jul 17, 2026
| } | ||
|
|
||
| #[pallet::authorize(Self::authorize_dispatch_whitelisted_call)] | ||
| #[pallet::weight_of_authorize(T::DbWeight::get().reads(1))] |
Contributor
There was a problem hiding this comment.
I am not sure about this hard-coded weights, should have proper benchmarking
Contributor
Author
There was a problem hiding this comment.
Both callbacks now use benchmarked weights (authorize_dispatch_whitelisted_call and authorize_dispatch_whitelisted_call_with_preimage(n)), measured via the Authorize trait as in pallet-im-online.
bkontur
reviewed
Jul 17, 2026
| _call_encoded_len: &u32, | ||
| _call_weight_witness: &Weight, | ||
| ) -> TransactionValidityWithRefund { | ||
| Self::authorize_whitelisted_dispatch(*call_hash) |
Contributor
There was a problem hiding this comment.
when we go this branch (expected Call is stored T::Preimages), shouldn't we also check T::Preimages::fetch(&call_hash, Some(call_encoded_len)) here? (Maybe just T::Preimages::len or something efficient)
Just thinking, if we whitelist_call_hash and expecting authorize_dispatch_whitelisted_call_with_preimage, then we basically allow anybody/unsigned to spam the chain for free with dispatch_whitelisted_call -> because it will pass unsigned/Authorized validation, but the extrinsic itself will fail on UnavailablePreImage and nobody will be charged for failed ones.
Also relates to my previous comment about hard-coded weight_of_authorize
Contributor
Author
There was a problem hiding this comment.
authorize_dispatch_whitelisted_call now rejects at the pool unless T::Preimages::len(call_hash) == Some(call_encoded_len), so a missing preimage or wrong length witness can't be relayed for free. Used len over fetch to keep it to one read.
The call_weight_witness can't be checked without decoding, so it stays in the dispatch body. The inline with_preimage variant already derives the hash from the call, so it's unaffected. New test coverage in authorize_dispatch_whitelisted_call_uses_hash_argument.
Contributor
Author
|
/cmd bench --pallet pallet_whitelist |
Contributor
|
Command "bench --pallet pallet_whitelist" has started 🚀 See logs here |
Contributor
|
Command "bench --pallet pallet_whitelist" has finished ✅ See logs here DetailsSubweight results:
Command output:❌ Failed benchmarks of runtimes/pallets: |
Contributor
Author
|
/cmd fmt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #12224
Adds
#[pallet::authorize]callbacks todispatch_whitelisted_callanddispatch_whitelisted_call_with_preimage: an unsigned submission is admitted at the pool only ifDispatchWhitelistedOrigin::try_origin(Authorized)passes and the call hash is inWhitelistedCall.Adds
frame_system::EnsureAuthorizedfor runtimes to opt in: