Skip to content

qa: PER-CS code style + composer hygiene; floor twig at 3.27 - #11

Merged
parisek merged 2 commits into
mainfrom
qa/tier1-quality-tooling
Jun 1, 2026
Merged

qa: PER-CS code style + composer hygiene; floor twig at 3.27#11
parisek merged 2 commits into
mainfrom
qa/tier1-quality-tooling

Conversation

@parisek

@parisek parisek commented Jun 1, 2026

Copy link
Copy Markdown
Owner

Brings twig-attribute onto the shared parisek QA baseline (mirrors timber-kit), with a formatter scoped to the Parisek-authored code.

What

  • PHP-CS-Fixer (@PER-CS) over AttributeExtension.php + tests/ only — the vendored Drupal classes in src/ deliberately keep Drupal's 2-space style so upstream refreshes stay diff-able. cs / cs:fix scripts + a cs CI job.
  • composer hygiene CIcomposer validate --strict + composer audit --abandoned=report + composer normalize --dry-run. Adds ergebnis/composer-normalize.
  • pin config.platform.php = 8.3 (the lock is committed here) so symfony/console resolves to a 7.x that installs on the floor.
  • Security: raise the twig/twig require floor to ^3.27 (CVE-2026-46634).

Notes

  • --abandoned=report because the tree has abandoned transitives (not vulnerabilities) — they shouldn't fail the security gate.
  • PHPStan stays level 5 — level 8 would flag the vendored Drupal src/, which must not be modified.

Part of unifying QA tooling across the parisek libraries.

🤖 Generated with Claude Code

parisek and others added 2 commits June 1, 2026 17:14
Brings twig-attribute onto the shared parisek QA baseline (mirrors
timber-kit), plus a formatter scoped to the Parisek-authored code:

- PHP-CS-Fixer (@PER-CS) over AttributeExtension.php + tests/ only; the
  vendored Drupal classes in src/ keep their 2-space style so upstream
  refreshes stay diff-able. `cs` / `cs:fix` scripts + a `cs` CI job.
- composer hygiene CI: validate + audit (--abandoned=report, the tree has
  abandoned transitives) + normalize. Adds ergebnis/composer-normalize.
- pin config.platform.php to 8.3 (lock is committed here) so symfony/console
  resolves to a 7.x that installs on the floor.
- **Security:** raise the twig/twig require floor to ^3.27 (CVE-2026-46634).

PHPStan stays level 5 — level 8 would flag the vendored Drupal src, which
must not be touched.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…rsist)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@parisek
parisek merged commit 9b8346d into main Jun 1, 2026
5 checks passed
@parisek
parisek deleted the qa/tier1-quality-tooling branch June 1, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant