Feat/capture container info - #50
Merged
Merged
Conversation
jamessewell
commented
May 22, 2026
jamessewell
commented
Collaborator
The metrics collector now grabs a curated docker-inspect subset (image, image_id, cmd, env, host_config, mounts, ports, labels, network_mode) per container, exposed via GetContainerInfo. The dashboard JSON adds a top-level backends block keyed by alias that holds config + pre/post + container_info once per backend instead of duplicating it inside every run. The dashboard frontend reads the new shape and adds a Container tab to the config modal alongside Config/Pre/Post. A BENCHMARKER_META env var (inline JSON or @file.json) stamps arbitrary metadata verbatim into the JSON's top-level meta field, for downstream publishing tools to attach commit/version/machine/links without the runner knowing about them. Per-dataset docker-compose.yml is now the recommended pattern: datasets/sample gets its own compose with just the services its scripts use. The repo-root compose stays as a kitchen-sink template for authoring new datasets. An explicit container: "" in the JS backend config opts a backend out of docker capture, for off-host services (RDS, managed Elasticsearch). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
loader pull now writes a small dataset.yaml at the dataset root recording the s3 source and pull timestamp. Absent file = local-only dataset. The k6 extension reads dataset.yaml at run time (if present) and auto-detects the running script's source by scanning os.Args for a .js/.ts/.mjs/.cjs path that exists on disk. Both are emitted in the dashboard JSON under top-level dataset_yaml, script, and script_path fields. Dashboard config modal gets Dataset and Script tabs that render only when their fields are present. The modal also opens for off-host backends now (empty container) whenever any global capture exists, so the script is reachable in those cases too. Drive-by: fix a JS ReferenceError where updateStats referenced data.backends but received only runs; pass backends explicitly. Trims the Container tab to identity (image, image_id, cpu_limit, memory_limit, cap_add, security_opt), cmd, and env — drops the duplicative/uninteresting mounts, ports, labels, network_mode, and raw host_config integers. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.