Add destination assertions to rule tests - #829
Conversation
PR SummaryLow Risk Overview Tests can now specify which destinations an alert should route to, with an empty list representing signal-only (no destination routing). The implementation creates test-specific destination instances for any expected destinations not available globally, then compares the actual routing output against the expected list to mark tests as failed if they don't match. Includes schema validation updates, test utilities, and regression test fixtures demonstrating the feature including a passing test case and a mismatch failure case. Reviewed by Cursor Bugbot for commit 8e1140f. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Other than the issue cursor flagged, LGTM. I'll wait on that fix to approve. Tag me when it's ready! |
36a8e64 to
269e893
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 269e893. Configure here.

Why
Rule YAML tests can currently observe destination routing but cannot assert whether a matching event should route an alert to a specific destination or remain signal-only (destination list is empty)
What
ExpectedDestinationslists to rule testsRisk Assessment
Low. Existing tests omit the optional field and retain their current behavior.