and Pantherflow query type - #580
Draft
debugmiller wants to merge 1 commit into
Draft
Conversation
arielkr256
reviewed
Feb 5, 2025
| "AnalysisType": Or("saved_query"), | ||
| "QueryName": And(str, NAME_ID_VALIDATION_REGEX), | ||
| Or("Query", "AthenaQuery", "SnowflakeQuery"): str, | ||
| Or("Query", "AthenaQuery", "SnowflakeQuery", "PantherFlowQuery"): str, |
Contributor
There was a problem hiding this comment.
@debugmiller does it make sense to also add this to the SCHEDULED_QUERY_SCHEMA?
Contributor
Author
There was a problem hiding this comment.
these can't be scheduled so I don't think so?
arielkr256
approved these changes
Feb 5, 2025
arielkr256
reviewed
Feb 12, 2025
| Or("Query", "AthenaQuery", "SnowflakeQuery", "PantherFlowQuery"): str, | ||
| Optional("Description"): str, | ||
| Optional("Tags"): [str], | ||
| Optional("Lookback"): bool, |
Contributor
There was a problem hiding this comment.
Does Lookback override | where p_event_time > time.ago(1d)?
arielkr256
marked this pull request as draft
February 12, 2025 18:50
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Changes
Testing