fix: two install/runtime crashes from the DCBO report (TOTP column leak + auditlog rule collision)

[rutgerhofste]

Fixes two separate issues reported by Mil Cuyvers (DCBO Open Solutions) via support@pantalytics.com, both hit while installing/using MCP Pro Governance on a database that already ran OCA auditlog with 2FA in use.

---

1. User form crashes: UndefinedColumn: auth_totp_device.x_role_id

Root cause

auth_totp.device uses prototype inheritance of our extended model:

class Auth_TotpDevice(models.Model):
    _name = 'auth_totp.device'
    _inherit = ["res.users.apikeys"]   # different _name → copies fields onto its own table
    _auto = False

So Odoo copies our x_role_id, x_state, x_last_used, x_use_count fields onto auth_totp.device too, but our init() hard-coded res_users_apikeys as the DDL target, so the columns were never created on auth_totp_device. Reading a user's trusted TOTP devices (the user-form onchange snapshots totp_trusted_device_ids) then hits the missing column. The customer's own diagnosis was spot-on.

Fix

init() is inherited by auth_totp.device (which defines none of its own), so it already runs for both models — it just always wrote to the wrong table. Keying every statement on self._table (via odoo.tools.SQL) provisions the columns on whichever table is being initialised. Existing DBs heal on upgrade; no manual migration.

Verified

On a fresh DB (auth_totp + module): before, auth_totp_device had none of the columns and the read crashed; after, both tables carry all four columns + indexes and the previously-crashing search_read returns cleanly.

---

2. Install aborts: UniqueViolation: auditlog_rule_model_uniq

Root cause

post_init_hook seeds a draft auditlog.rule per AI-target model, but auditlog.rule enforces unique(model_id) (one rule per model). The hook only skipped a model when a rule with our exact name already existed. A DB that already had an audit rule on that model under a different name (e.g. migrated from a pre-existing OCA auditlog install) tripped the constraint and the whole install failed.

Fix

Skip a model when any auditlog.rule already exists for it, leaving the operator's rule untouched.

Verified

On a fresh DB with a pre-existing partner rule under a different name, the old hook raised UniqueViolation: auditlog_rule_model_uniq; after the change the hook skips the model and installs cleanly.

---

Housekeeping

• Regression tests: TestApiKeyFieldsOnTotpDevice and TestPostInitHook.test_preexisting_rule_on_model_does_not_break_install.
• Manifest → 19.0.1.20.3, CHANGELOG updated.
• Single 19.0 branch serves 17/18/19; the customer is on the 18.0.x build and both fixes are version-agnostic (odoo.tools.SQL exists since 17.0), so all published builds are covered.

🤖 Generated with Claude Code