Allow exptime to be entered as a string fraction (#1367)#1461
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1461 +/- ##
==========================================
+ Coverage 69.29% 69.61% +0.32%
==========================================
Files 102 102
Lines 9870 9990 +120
Branches 846 856 +10
==========================================
+ Hits 6839 6955 +116
- Misses 2852 2853 +1
- Partials 179 182 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1367. This PR allows the camera times and scheduler observation times to be entered as a string fraction, such as '1/4'. Additionally, it updates the Canon DSLR driver to ensure that if the discrete shutterspeed table clips the requested exposure time (e.g. for tiny values like '1e-20'), the actual clipped physical shutterspeed is written to the FITS header instead of the requested value.