Skip to content

Allow exptime to be entered as a string fraction (#1367)#1461

Merged
wtgee merged 10 commits into
mainfrom
issue-1367-fractional-exptime
Jun 5, 2026
Merged

Allow exptime to be entered as a string fraction (#1367)#1461
wtgee merged 10 commits into
mainfrom
issue-1367-fractional-exptime

Conversation

@wtgee

@wtgee wtgee commented Jun 4, 2026

Copy link
Copy Markdown
Member

Closes #1367. This PR allows the camera times and scheduler observation times to be entered as a string fraction, such as '1/4'. Additionally, it updates the Canon DSLR driver to ensure that if the discrete shutterspeed table clips the requested exposure time (e.g. for tiny values like '1e-20'), the actual clipped physical shutterspeed is written to the FITS header instead of the requested value.

@codecov

codecov Bot commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.49593% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.61%. Comparing base (834b5af) to head (905aa2f).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
tests/test_camera.py 90.76% 4 Missing and 2 partials ⚠️
src/panoptes/pocs/camera/simulator/dslr.py 94.73% 0 Missing and 1 partial ⚠️
src/panoptes/pocs/scheduler/observation/base.py 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1461      +/-   ##
==========================================
+ Coverage   69.29%   69.61%   +0.32%     
==========================================
  Files         102      102              
  Lines        9870     9990     +120     
  Branches      846      856      +10     
==========================================
+ Hits         6839     6955     +116     
- Misses       2852     2853       +1     
- Partials      179      182       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wtgee wtgee merged commit 02309fc into main Jun 5, 2026
3 checks passed
@wtgee wtgee deleted the issue-1367-fractional-exptime branch June 5, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow exptime to be entered as a string fraction.

1 participant