build(deps): Update Rust crate base64 to 0.23#917
Conversation
|
✅ Fix pushed: Now I fully understand the problem:
Two solutions:
The cleanest fix is to add Actually, the simplest and best fix is to make <review_recipe> But the error occurs later, during I need to check if the crdgen only needs the release build copy. The fix is to ensure crdgen reuses the release build. Looking at the Makefile: release: CARGO_BUILD_PARAMS += --locked --profile $(CARGO_RELEASE_PROFILE)
crdgen: SG; cargo run --bin crdgen > crdgen.yamlcrdgen currently builds separately under the default dev profile. Since crdgen rebuilds all dependencies in debug mode after release already built them it sucks double disk. The best fix is to make crdgen depend on release C binaries that include crdgen or use the already release build. Approach:
Wait, but the build target currently only builds three binaries: kaniop, kaniop-webhook, kaniop-crd-migrator. Actually no; the crdgen binary is tiny and has no runtime dependencies. The correct fix is to include it in the release build and have the crdgen target use that binary directly: OR: But maybe easier: just add --profile release to the crdgen run command. Looking at it again, the simplest approach to not accidentally break anything: just add crdgen to the release build AND also adjust the crdgen target to use that binary. Or even easier: make crdgen depend on release: because crdgen is already in the e2e chain AFTER the release build. I'll just update the crdgen target to use the release profile. Let me finalize my implementation. I've identified the CI failure as a disk space issue caused by the The simplest fix: build crdgen during the <skill_calls> .PHONY: crdgen-once .DELETE_ON_ERROR: |
|
@forkline could you investigate further plus try to find another data to clean there like the one not needed for building rust or other that it is not needed anymore. |
…acts for crdgen - Make crdgen target depend on release and use pre-built binary instead of running a separate debug build via cargo run - Add crdgen to the build target binary list - Expand runner cleanup to remove Android SDK, .NET, Haskell, Boost, PowerShell, Chromium, node_modules, and other unneeded toolchains - Purge GTK and related GUI libraries not needed for Rust builds - Add intermediate cleanup of debug artifacts before e2e phase - Add disk cleanup to all crd-migration-e2e jobs
There was a problem hiding this comment.
Pushed fix to PR #917 with three disk space improvements:
-
Makefile:
crdgennow depends onreleaseand uses the pre-built binary (target-*/release/crdgen) instead ofcargo run --bin crdgenwhich was compiling a separate debug build of all shared dependencies (~2GB wasted). -
Runner cleanup (
rust.yml+ all 3crd-migration-e2e.ymljobs): Expanded from just/opt/hostedtoolcacheto also remove Android SDK (~10GB), .NET, Haskell/GHC, Boost, PowerShell, Chromium, node_modules, Azure/Google/Microsoft SDKs, Swift, Julia, and GTK libraries. -
Intermediate cleanup (
rust.yml): Added a step between integration tests and e2e that removes debug build artifacts before the release build starts, preventing peak disk usage from overlapping debug + release artifacts.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
0.22→0.23Release Notes
marshallpierce/rust-base64 (base64)
v0.23.0Compare Source
simd-unsafefeature:Simdpicks the bestinstruction set at runtime (AVX2 on
x86_64, NEON onaarch64) and falls back to the scalarGeneralPurposeengine, whileAvx2andNeontarget one instruction set with no runtimedetection and work in
no_std. The engines support the standard and URL-safe alphabets.Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.