Interface name conflict

CHANGELOG.md

@@ -1,3 +1,6 @@
+## 0.12.0
+- Add suffix to member name for interfaces with the same name from different namespaces to resolve conflict (https://github.com/pakrym/jab/pull/187).
+
 ## 0.11.0
 - Factory-created services are now correctly disposed (https://github.com/pakrym/jab/pull/179).
 

README.md

@@ -18,7 +18,7 @@ Jab provides a [C# Source Generator](https://devblogs.microsoft.com/dotnet/intro
 Add Jab package reference:
 ```xml
 <ItemGroup>
-    <PackageReference Include="Jab" Version="0.11.0" PrivateAssets="all" />
+    <PackageReference Include="Jab" Version="0.12.0" PrivateAssets="all" />
 </ItemGroup>
 ```
 
@@ -283,7 +283,7 @@ A minimal example ends up looking like this:
     }
   ],
   "dependencies": {
-    "com.pakrym.jab": "0.11.0",
+    "com.pakrym.jab": "0.12.0",
     ...
   }
 }

src/Jab.Attributes/Jab.Attributes.csproj

@@ -6,7 +6,7 @@
         <LangVersion>preview</LangVersion>
         <RootNamespace>Jab</RootNamespace>
         <DefineConstants>$(DefineConstants);JAB_ATTRIBUTES_PACKAGE;GENERIC_ATTRIBUTES</DefineConstants>
-        <Version>0.11.0</Version>
+        <Version>0.12.0</Version>
         <Version Condition="'$(ReleaseVersion)' != ''">$(ReleaseVersion)</Version>
         <PackageReadmeFile>README.md</PackageReadmeFile>
         <PackageLicenseExpression>MIT</PackageLicenseExpression>

src/Jab.FunctionalTests.Common/ContainerTests.cs

@@ -1,11 +1,12 @@
 #nullable enable
+using Jab;
 using System;
 using System.Collections.Generic;
+using System.Linq;
+using System.Reflection;
 using System.Threading.Tasks;
 using Xunit;
 
-using Jab;
-
 namespace JabTests
 {
     public partial class ContainerTests
@@ -1448,6 +1449,36 @@ public void SupportsNoneTransientValueType()
         internal partial class SupportsNoneTransientValueTypeContainer
         {
         }
+
+
+        [Fact]
+        public void GeneratesDistinctMembersForSameLocalNameAcrossNamespaces()
+        {
+            var c = new NameCollisionContainer();
+
+            var foo1 = c.GetService<IService>();
+            var foo2 = c.GetService<NestedNS.IService>();
+
+            Assert.NotNull(foo1);
+            Assert.NotNull(foo2);
+            Assert.NotSame(foo1, foo2);
+
+            // Verify distinct private cache fields were generated (e.g. _IFoo_0, _IFoo_1)
+            var fields = typeof(NameCollisionContainer)
+                .GetFields(BindingFlags.Instance | BindingFlags.NonPublic)
+                .Where(f => f.Name.StartsWith("_IService", StringComparison.Ordinal))
+                .Select(f => f.Name)
+                .Distinct()
+                .ToArray();
+
+            Assert.Equal(2, fields.Length);
+            Assert.NotEqual(fields[0], fields[1]);
+        }
+
+        [ServiceProvider]
+        [Singleton(typeof(IService), typeof(ServiceImplementation))]
+        [Singleton(typeof(NestedNS.IService), typeof(NestedNS.ServiceImplementation))]
+        internal partial class NameCollisionContainer { }
     }
 }
 

src/Jab.FunctionalTests.Common/Mocks/NestedNS/IService.cs

@@ -0,0 +1,12 @@
+using Jab;
+
+namespace JabTests.NestedNS
+{
+    internal interface IService
+    {
+    }
+    internal interface IService<T>
+    {
+        T InnerService { get; }
+    }
+}

src/Jab.FunctionalTests.Common/Mocks/NestedNS/ServiceImplementation.cs

@@ -0,0 +1,18 @@
+using Jab;
+
+namespace JabTests.NestedNS
+{
+    internal class ServiceImplementation : IService
+    {
+    }
+
+    internal class ServiceImplementation<T> : IService<T>
+    {
+        public ServiceImplementation(T innerService)
+        {
+            InnerService = innerService;
+        }
+
+        public T InnerService { get; }
+    }
+}

src/Jab.Unity/package.json

@@ -1,6 +1,6 @@
 {
   "name": "com.pakrym.jab",
-  "version": "0.11.0",
+  "version": "0.12.0",
   "description": "C# Source Generator based dependency injection container implementation.",
   "licensesUrl": "https://github.com/pakrym/jab/blob/main/LICENSE",
   "repository": {