Repository navigation
build(deps): consolidate Dependabot bumps (#3, #9, #10) and clear pnpm audit - #14
Merged
Merged
Conversation
Fold the in-major Dependabot updates (#3, #9, #10) into one change and refresh the lockfile so `pnpm audit` (run in CI with no audit level) reports no vulnerabilities: - vite ^8.3.4, vitest ^4.1.12, @playwright/test ^1.64.1, eslint ^10.13.0, globals ^17.13.0, prettier ^3.9.10 - three ^0.185.1, @types/three ^0.185.4 - transitive refresh: postcss 8.5.31, nanoid 3.3.20, source-map-js 1.2.2, brace-expansion 5.0.12, @vitest/mocker 4.1.12 Majors deferred: typescript 7 (#11), actions/checkout v7 (#4), actions/setup-node v7 (#8).
Playwright 1.64's headless Chromium 156 renders this scene through SwiftShader roughly half as fast as Chromium 148 (Playwright 1.60), so the countdown that precedes the first HUD update now takes ~7-8 s on a 2-CPU runner instead of ~4 s. That overruns the fixed 1.5 s wait plus the default 5 s expect timeout. Bisected in the Playwright Docker image: vite and three versions make no difference. Raise only this assertion's timeout to 20 s.
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR folds the in-major Dependabot PRs into one branch and makes the
pnpm auditstep of Typecheck · Lint · Format · Test · Build pass.On
main,pnpm auditreports 21 findings: 1 low, 9 moderate and 11 high. CI runspnpm auditwith no--audit-level, so every finding fails the job. On this branch, the result isNo known vulnerabilities found. All 11 open Dependabot alerts are cleared.The PR changes
package.json,pnpm-lock.yamland one e2e assertion timeout. It does not changepackageManager, which is #12's change, and it does not changeci.yml, because both action bumps are majors.Superseded PRs
^8.3.4^1.64.1,^10.13.0,^17.13.0,^3.9.10,^8.3.4,^4.1.12^0.185.1,^0.185.4Each version taken is the newest in its current major that was published at least 3 days ago. vite 8.3.5 was published on 2026-10-21, so this PR stops at 8.3.4.
three r185: Under caret rules,
^0.184does not include 0.185, so I checked the r184 → r185 entries in the migration guide. Every entry covers WebGPU/TSL nodes, loaders and exporters,Matrix3helpers, ormatrixAutoUpdate.src/uses none of them: it uses the core WebGL classes andthree/addons/postprocessing(EffectComposer, RenderPass, UnrealBloomPass, ShaderPass). Build, unit tests and e2e all pass. I stayed on the r185 line that Dependabot proposed and did not move to 0.186.Deferred (major)
src/ui/menus.js(lines 22 and 65):new Promise((res) => …)incheckJsmode needs aPromise<void>JSDoc hint beforeres()can be called with no arguments.pull_request_target/workflow_run(release notes). This repo triggers only onpushandpull_request, so no impact is expected.NODE_AUTH_TOKENexport (release notes). Both jobs use onlynode-versionandcache: pnpm, and nothing publishes to npm, so no impact is expected.Not touched: #12 (Node/pnpm migration) and #13 (Renovate onboarding).
Fixes (pre-existing and upgrade-caused)
The
pnpm auditstep was failing onmain(21 findings), and the test and build steps after it never ran in CI. This PR fixes the audit. Locally, both test and build pass.The e2e smoke test fails with Playwright ≥ 1.62. This is upgrade-caused and is the same failure build(deps-dev): bump the dev-dependencies group with 6 updates #9 hit:
#lapis still empty after the fixed 1.5 s wait plus the default 5 s timeout. I reproduced it in themcr.microsoft.com/playwrightDocker image with 2 CPUs and bisected it:LAPThe newer headless Chromium renders this scene more slowly under SwiftShader. The vite and three versions make no difference, and there was no dev-server reload or console error. The fix is test-only: that one assertion's timeout goes to 20 s (
tests/e2e/smoke.spec.js), and the game code is unchanged. With the fix, three runs in Docker passed.Security audit
Every finding comes in through a devDependency (vite, vitest, eslint) and none reaches the shipped bundle. All of them are fixed by updates within the current major. No overrides and no audit ignores were added.
pnpm update brace-expansion --depth Infinity. This is a lockfile refresh within minimatch 10.2.5's range.3-day release age
I resolved with
--config.minimum-release-age=4320. I then checked every newname@versionin the lockfile diff (67 entries) against the npm registrytimefield. The newest is postcss 8.5.31, published 2026-10-18 19:39 UTC. There are no exceptions.Verification
Run locally with Node 26.12.1 and pnpm 11.2.2 (
packageManager), starting from a cleannode_modules:🤖 Generated with Claude Code