perf: lazy check_output formatting and declare UX fixes - #4
Merged
Conversation
- strip typedr_value metadata before returning - align implicit and explicit typed function returns
- collapse multi-line deparsed calls before measuring width - fall back to factory names instead of Type() for long single-factory assertions
pacmandoh
force-pushed
the
perf/phase-1-lazy-check-output
branch
from
June 10, 2026 06:40
ac6f4d6 to
bbcfde5
Compare
- declare pkgload in Suggests for the test helper - cover check_output peel paths and declare unset inform guards - simplify typedr_value peeling and centralize unset inform checks
pacmandoh
force-pushed
the
perf/phase-1-lazy-check-output
branch
from
June 10, 2026 06:41
bbcfde5 to
7f29836
Compare
- route interactive() through mockable .typedr_is_interactive() - assert inform content via mocked cli_inform instead of catch_cnd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_output()assertion labeling and type formatting until the failure path, reducing work on successful typed returns.check_output()success paths by stripping internaltypedr_valuemetadata.Test plan
devtools::test()— full test suite passes locallydeclare()unset inform in interactive sessionCharacter()in parent error callMade with Cursor