Skip to content

Change which files are modified #448 - #711

Merged
johnmhoran merged 2 commits into
mainfrom
448-subpath-build-parse
Oct 23, 2025
Merged

Change which files are modified #448#711
johnmhoran merged 2 commits into
mainfrom
448-subpath-build-parse

Conversation

@johnmhoran

@johnmhoran johnmhoran commented Oct 23, 2025

Copy link
Copy Markdown
Member

This PR consolidates and updates changes originally proposed in #449 and #458. Both PRs were opened by @jkowalleck , trace their parentage to his #448, and concern changes to the same file -- purl-specification.md.

The original target file is actually compiled from a group of individual .md files. This PR transfers the author's original changes to their respective source files -- docs/how-to-build.md and docs/how-to-parse.md.

@jkowalleck -- thank you for your original issue and PRs. Please let me know if this PR needs any updates to accurately reflect your PRs.


Reference: #448
Signed-off-by: johnmhoran <johnmhoran@gmail.com>
@mjherzog

Copy link
Copy Markdown
Member

@johnmhoran Is there a reason why you did not apply the 78 character line limit for how-to-parse.md?

@johnmhoran

Copy link
Copy Markdown
Member Author

Thanks for the heads-up @mjherzog -- I was focused on the changes and overlooked the line length in that file, will update.

Reference: #448
Signed-off-by: johnmhoran <johnmhoran@gmail.com>

@mjherzog mjherzog left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mjherzog
mjherzog requested a review from jkowalleck October 23, 2025 00:50
Comment thread docs/how-to-build.md
- Append '#' to the `purl`
- Strip the `subpath` from leading and trailing '/'
- Split this on '/' as segments
- Divide the `subpath` into segments using the path delimiter of your

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread docs/how-to-parse.md
- Report an error if any segment contains a slash `/`
- Join segments back with a '/'
- This is the `subpath`
- This list of path segments is the ``subpath``

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnmhoran
johnmhoran merged commit bbf3137 into main Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants