Change which files are modified #448 - #711
Merged
Merged
Conversation
Reference: #448 Signed-off-by: johnmhoran <johnmhoran@gmail.com>
This was referenced Oct 23, 2025
Member
|
@johnmhoran Is there a reason why you did not apply the 78 character line limit for how-to-parse.md? |
Member
Author
|
Thanks for the heads-up @mjherzog -- I was focused on the changes and overlooked the line length in that file, will update. |
Reference: #448 Signed-off-by: johnmhoran <johnmhoran@gmail.com>
jkowalleck
approved these changes
Oct 23, 2025
| - Append '#' to the `purl` | ||
| - Strip the `subpath` from leading and trailing '/' | ||
| - Split this on '/' as segments | ||
| - Divide the `subpath` into segments using the path delimiter of your |
Member
There was a problem hiding this comment.
| - Report an error if any segment contains a slash `/` | ||
| - Join segments back with a '/' | ||
| - This is the `subpath` | ||
| - This list of path segments is the ``subpath`` |
Member
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consolidates and updates changes originally proposed in #449 and #458. Both PRs were opened by @jkowalleck , trace their parentage to his #448, and concern changes to the same file --
purl-specification.md.The original target file is actually compiled from a group of individual
.mdfiles. This PR transfers the author's original changes to their respective source files --docs/how-to-build.mdanddocs/how-to-parse.md.@jkowalleck -- thank you for your original issue and PRs. Please let me know if this PR needs any updates to accurately reflect your PRs.