add test for percent signs - #273
Open
matt-phylum wants to merge 2 commits into
Open
Conversation
matt-phylum
added a commit
to phylum-dev/purl
that referenced
this pull request
Nov 20, 2023
matt-phylum
added a commit
to phylum-dev/purl
that referenced
this pull request
Nov 22, 2023
* encode percent signs * use same test as package-url/purl-spec#273
Member
|
@matt-phylum here too, after the merge of PR #514, PURL tests and defs are now defined in new JSON schema 👼 😇 😁 : .... this PR needs to be updated. Sorry for the pain. Thank you for your patience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a simple test that percent signs are correctly encoded and decoded in all parts of a PURL. Some implementations don't correctly handle percent encoding in all allowed positions (giterlizzi/perl-URI-PackageURL, maennchen/purl, package-url/packageurl-ruby, package-url/packageurl-swift, sonatype/package-url-java) and some implementations don't encode percent signs (althonos/packageurl.rs, anchore/packageurl-go, phylum-dev/purl).