I12 async ncpartitioner - #13
Open
QSparks wants to merge 4 commits into
Open
Conversation
QSparks
force-pushed
the
i12-async-ncpartitioner
branch
from
June 22, 2026 16:54
d01e424 to
49a7e91
Compare
QSparks
force-pushed
the
i12-async-ncpartitioner
branch
2 times, most recently
from
June 30, 2026 20:53
00a3a2e to
5054a6e
Compare
QSparks
force-pushed
the
i12-async-ncpartitioner
branch
4 times, most recently
from
July 9, 2026 16:50
2ed1c68 to
3849986
Compare
QSparks
force-pushed
the
i12-async-ncpartitioner
branch
from
July 9, 2026 17:16
3849986 to
6701efb
Compare
QSparks
marked this pull request as ready for review
July 27, 2026 21:39
Nospamas
approved these changes
Aug 27, 2026
Nospamas
left a comment
Nospamas
left a comment
There was a problem hiding this comment.
Complex code, nothing stands out as bad though the download.js is getting (perhaps justifiably due to its complexity) large.
Added a note about the use of alert() but otherwise things look good. We've tested this through against the dev copy so I'm happy with this to move through.
| } | ||
| if (subsetDownloadBtn.disabled) return; | ||
| if (!state.currentDataset) return alert('Please select a dataset first'); | ||
| if (!state.variable) return alert('Could not infer variable for this file.'); |
There was a problem hiding this comment.
tend to prefer not to use alert() (or confirm() or input()) in modern javascript, they're synchronous blocking events and somewhat user hostile. Won't fail the review for it, but i'd look at replacing these with inline validation flags, toasts or html modals if needs be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.