Skip to content

I33 lighthouse - #35

Merged
QSparks merged 6 commits into
i31-Peace-Columbiafrom
i33-lighthouse
Aug 4, 2026
Merged

I33 lighthouse#35
QSparks merged 6 commits into
i31-Peace-Columbiafrom
i33-lighthouse

Conversation

@QSparks

@QSparks QSparks commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Performance and accessibility improvements suggested by lighthouse .
Resolves #33

@QSparks
QSparks requested a review from Nospamas July 21, 2026 15:22
@QSparks QSparks self-assigned this Jul 21, 2026

@Nospamas Nospamas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, approved.

Comment thread docker/app/server.js
const http = require("node:http");
const fs = require("node:fs");
const path = require("node:path");
const zlib = require("node:zlib");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here seem to serve their purpose but I don't love that we're writing our own server when something like nginx might serve better for a static site like this.

Out of scope to change that here though. We should look at working out a template for how all our frontends work and apply it consistently.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I've opened #38.

@Nospamas Nospamas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@QSparks
QSparks merged commit 87909b2 into i31-Peace-Columbia Aug 4, 2026
1 check passed
QSparks added a commit that referenced this pull request Aug 4, 2026
* I31 peace columbia (#32)
* I33 lighthouse (#35), 
* I34 controlled startup (#36)
* I37 bulk download (#39)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants