Skip to content

Update KrylovKit compat bound, extend CI to recent Julia versions #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pablosanjose wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update KrylovKit compat bound, extend CI to recent Julia versions #405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7088d4
up KrylovKit compat bound, extend CI to recent Julia versions
pablosanjose Jul 30, 2026
3e862a3
fix for sparse eigenvectors from KrylovKit
pablosanjose Jul 31, 2026
a09ba01
another eps try
pablosanjose Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ jobs:
version:
- '1'
- 'lts'
# - 'pre'
# - 'nightly'
- 'pre'
- 'nightly'
os:
- ubuntu-latest
- windows-latest
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ FrankenTuples = "0.1"
FunctionWrappers = "1.1.3, 1.2, 1"
GeometryBasics = "0.5, 1"
IntervalTrees = "1"
KrylovKit = "0.6, 0.7"
KrylovKit = "0.6, 0.7, 0.10.4"
LinearMaps = "3"
Makie = "0.24, 1"
NearestNeighbors = "0.4"
Expand Down
2 changes: 2 additions & 0 deletions src/sanitizers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,8 @@ sanitize_eigen(ε::AbstractVector, Ψs::AbstractVector{<:AbstractVector}) =
sanitize_eigen(ε, Ψ) = Eigen(sorteigs!(sanitize_eigen(ε), sanitize_eigen(Ψ))...)
sanitize_eigen(x::AbstractArray{<:Real}) = complex.(x)
sanitize_eigen(x::AbstractArray{<:Complex}) = x
# some eigensolvers (e.g. KrylovKit) return sparse arrays. EigenComplex assumes dense matrices.
sanitize_eigen(x::AbstractSparseMatrix{T}) where {T} = convert(Matrix{complex(T)}, x)

function sorteigs!(ϵ::AbstractVector, ψ::AbstractMatrix)
p = Vector{Int}(undef, length(ϵ))
Expand Down
4 changes: 2 additions & 2 deletions src/solvers/green/schur.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ function schur_pencil!(s::SchurFactorsSolver, ω)
A, B = pencilAB!(s)
sch = schur!(A, B)
# disallow zeros in deflated α's or β's for real ω
tol = 5*eps(real(typeof(ω)))
tol = 10*eps(real(typeof(ω)))
if iszero(imag(ω)) && (any(x->abs(x)<tol, sch.α) || any(x->abs(x)<tol, sch.β))
# Schur pencil has zero α or β. Recomputing with imag(ω) = tol to avoid singular pencil
sch = schur_pencil!(s, ω + im * tol)
Expand Down Expand Up @@ -293,7 +293,7 @@ minimal_callsafe_copy(s::SchurWorkspace) =
- For this to work correctly the propagating eigenvalues should come first.
=#

function ordschur_retarded!(sch::GeneralizedSchur{Complex{T}}, s::SchurFactorsSolver, ω; tol = 5*eps(T)) where {T}
function ordschur_retarded!(sch::GeneralizedSchur{Complex{T}}, s::SchurFactorsSolver, ω; tol = 10*eps(T)) where {T}
whichmodes, V´, VZ = s.tmp.whichmodes, s.tmp.V1, s.tmp.V2
@. whichmodes = abs(sch.β)-tol < abs(sch.α) < abs(sch.β)+tol # propagating
if any(whichmodes) # classify propagating modes using velocity
Expand Down
Loading