fix printf size arguments#79
Closed
Un1q32 wants to merge 1 commit into
Closed
Conversation
Owner
|
Conflicts with #81 (which I consider a fairly valuable proposal), and just generally not that big of an issue? I doubt it'd print wrong values given that the input is a file size for block/player data. It's not going to be exceeding 32 bits in normal use. |
Contributor
Author
|
maybe just do %lu and silence the warn then? long should always be the same width as size_t on 32 and 64 bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the z size argument for printf specifies size_t sized numbers, this would previously produce warnings on some compilers and also might print the wrong value on 64 bit systems.