Repository navigation
test: retain network summary diagnostics and prefix reproduction (#569) - #568
Conversation
|
Blocked on bench-ci#1144: approved CI list and narrow reproduction submission now fail with connection refused. No job id was returned, so no hardware result or passing reproduction is claimed. Bench maintainers must restore endpoint availability; resume the same The bounded diagnostic change, required focused regression (22 assertions), documentation and author-side verifier/security reviews are complete in draft PR #568. Full historical job logs and the sole artifact were read, but they lack the observations needed to establish the cause. Root-cause diagnosis and correction remain unfinished. Once a recovered/new diagnostic job completes, read its full logs/artifacts, renew generated evidence and continue on this same PR. No manual bench or rig action was performed. |
|
The operator closed bench-ci#1144 after restoring endpoint availability. The original idempotency key resumed submission as job |
|
The completed isolated network job |
|
Audited completed job No product code or strict assertion was changed, and the original cause remains unproved. This issue retains the intermittent failure and is also labeled |
Ready for reviewThis PR owns diagnostics prerequisite #569; #563 remains the unresolved failure. At All eight current-head GitHub checks passed. The focused gate driver passed 62 assertions; mutations removing the instrumentation or sequence fail the relevant regressions. Completed job No root cause or corrective fix for #563 is claimed. Later unrelated hardware phases were omitted by design; the completed tier4 run covers the diagnostic scope. Local full-suite/container execution was omitted in favor of the actual GitHub checks, and local Markdown tooling was unavailable; the GitHub Markdown check passed. The code head is unchanged, so its completed proof remains current. Please route prerequisite #569 / this draft PR to a separate reviewer session at that head, re-derive the evidence, and record the required |
|
The operator split the tested diagnostic work into #569 on #563 is blocked on #569 landing: the diagnostic code must be available to the scheduled nightly before a recurrence can supply the missing observations. The implementation, mandatory regressions, documentation, author-side reviews, all eight current-head GitHub checks and audited tier4-e2e job |
|
adversarial-review: PASS at 48b2270, round 1, by the pithead-reviewer reviewer (a fresh session that did not produce this head; gpt-6.1-sol). PASS at 48b2270 for #569: sanitized boolean diagnostics, preserved strict assertion and restoration, and a tested same-process nightly-prefix reproduction. Current-head GitHub checks and deployed tier4 evidence hold; #563 remains unresolved. Evidence
Findings
|
Closes #569
Related unresolved failure: #563.
The nightly network phase reports a combined metadata/key-superset failure without retaining which condition failed. This draft adds fixed boolean
network-summaryobservations from the same responses, omitting bodies, key names, timestamps and parser errors. The original strict assertion, failure row and configuration lifecycle remain intact. The required regression and test documentation cover the diagnostic behavior.The isolated
networkreproduction passed, so it does not establish the nightly root cause. A new narrownetwork-sequencephase reproduces the nightlyconnect→worker-api→api-impact→networkprefix in one process and snapshot, stopping after network. Separate phase submissions restore between invocations and cannot preserve that state. Fatal failures and failed rows stop the sequence through the existing cleanup path. This targets the original failing sequence without running unrelated later phases.Decisions taken
maintenance & gates. The unresolved failure #563 remains open. The later owner ruling of 2026-10-03 moved it tomaintenance & gatesas a soak watch; a recurrence in the gated run or soak returns it to the release scope. No second implementation or PR was created.tests/e2e-pithead.shremain intact.48b227098a8eae72503de741de18d12d740fe6b3is unchanged. Completed job2054@48b227098a8eae72503de741de18d12d740fe6b3supplies current-head tier4-e2e proof; any head change requires fresh evidence.Ponytail review: retained bounded diagnostics, the minimal same-process reproduction phase, mandatory regressions and corrected documentation; no retry, relaxed assertion, product change or new dependency.
Validation at
48b227098a8eae72503de741de18d12d740fe6b3:timeout 60 bash "$TMPDIR/rigforge-563-summary-unit.sh"— PASS, 27 assertions. The scratch driver uses repository assertion helpers and sourcestests/test-summary-diagnostics.sh; no hardware used.timeout 60 bash "$TMPDIR/rigforge-563-gates-unit.sh"— PASS, 62 assertions. The same driver sources the existingtests/test-e2e-gate-fail-closed.sh, including the new dispatch regression.shellcheck --severity=warning tests/e2e-summary-diagnostics.sh tests/test-summary-diagnostics.sh tests/test-e2e-gate-fail-closed.sh— PASS. The main harness reports baseline SC2120 under local ShellCheck 0.9.0; complete local ShellCheck PASS is not claimed. GitHub uses pinned 0.11.0.shfmt -i 4 -d tests/e2e-pithead.sh tests/e2e-summary-diagnostics.sh tests/test-summary-diagnostics.sh tests/test-e2e-gate-fail-closed.sh,FILE_BUDGET_REQUIRE_BASE=1 bash scripts/lint-file-budget.sh,make lint-topology,git diff --cached --check— PASS.All eight required GitHub checks passed at current head
48b227098a8eae72503de741de18d12d740fe6b3: suite, Docker e2e, coverage, shell/Markdown/YAML lint, secret scan and workflow audit. Complete suite and container e2e were not run locally.Job 2052's full status, complete log and sole retained artifact were read. The network metadata/key contract and secret-leak checks passed with verified restoration. Its diagnostic flags show valid metadata, matching keys and no unreachable-miner marker. This proves the isolated phase on that head, not the preceding nightly sequence. That isolated run alone did not establish intermittent behavior because its phase sequence differed from the nightly. The subsequent
network-sequencejob runs the same prefix through the original assertion, which passed without any product code or assertion change. The related original issue #563 is also labeledflaky; the failure is not attributed to product logic or bench timing without causal evidence.Endpoint access recovered under bench-ci#1144; its infrastructure cause is tracked separately in bench-ci#1146. The missing submitter guide remains tracked in bench-ci#1028. The queued evidence ID mismatch is tracked in bench-ci#922; both completed reproduction blocks now print consistent submitted IDs. All evidence below was regenerated after completion and retained unedited.
Historical nightly evidence (symptom/restoration only):
bench-ci job 349@a625d1d497978d320a6e1b01125717fdbec667ca · rigforge · tier4-e2e
Generated by
bench-ci evidence 349@a625d1d497978d320a6e1b01125717fdbec667ca; re-run it to check.Isolated network reproduction:
bench-ci job 2052@7088ca6a402c0910519d81013c799b848709d737 · rigforge · tier4-e2e
Generated by
bench-ci evidence 2052@7088ca6a402c0910519d81013c799b848709d737; re-run it to check.Nightly-prefix reproduction (no failure reproduced):
bench-ci job 2054@48b227098a8eae72503de741de18d12d740fe6b3 · rigforge · tier4-e2e
Generated by
bench-ci evidence 2054@48b227098a8eae72503de741de18d12d740fe6b3; re-run it to check.