Repository navigation
fix(e2e-real): standalone perf gate must exit nonzero on a regression (#214 follow-up) - #281
Merged
Merged
Conversation
VijitSingh97
enabled auto-merge (squash)
July 17, 2026 02:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sudo bash tests/e2e-real.sh perf(the release perf gate per RELEASING.md) printed a red✗ perf REGRESSIONline but still exited 0, so any scripted check of the exit code would pass a regressing release.perf()now ends every path throughsummary "perf", mirroring howprovision/verify/teardownend —summaryis what convertsFAIL>0intoexit 1. All five earlyreturn 0paths (bench failure, unparseable hashrate, record-mode regression refusal, record-mode success, no-baseline) now flow throughsummary "perf"too.allmode a perf failure is now attributed to perf (the run stops at perf's summary), not misattributed to teardown.ok/bad/summaryfrom e2e-real.sh (verbatim, same technique as the rig_lock tests) and asserts onperf()'s real exit status — nonzero on a stubbed regression, 0 on a pass. Onlyphaseand the bench remain stubbed.provision,verify, andteardownall already end insummarywith no earlyreturnafter abad(verify's one earlyreturnis a clean SKIP that goes throughsummary "verify"first). Onlyperfhad the bug.Verified: the reworked test goes red against the pre-fix
perf()(the two exit-code assertions fail with rc=0) and green with the fix.make test: 1332 passed, 0 failed.Closes #267
🤖 Generated with Claude Code