Repository navigation
Validate config inputs before building (DONATION integer, hostname) #8
Description
Problem
DONATION is read from config.json (rigforge.sh:107) and then sed'd into the XMRig source (donate.h, :235/:242) and --argjson'd into jq (:359) with no validation. A non-integer/garbage value breaks the build opaquely or risks injecting into source before compile. Other inputs (hostname) are also unvalidated.
Proposed
- Validate
DONATIONis an integer within XMRig's allowed range (0–100) before patching/build; fail fast with a clear message. - Sanity-check
P2POOL_NODE_HOSTNAME(non-empty, reasonable charset).
Acceptance
- Invalid
DONATION/hostname is rejected with a clear error before any source patch or build.
Activity
VijitSingh97 commentedon Jun 6, 2026
Partially implemented by #26 (which closes #5).
The DONATION half is done:
parse_confignow rejects a non-integer or out-of-range value (allowed 0–100) with a clear error before anydonate.hpatch or build, and it's covered by the test suite (accepts0/1/100; rejects101,-1,1.5,abc).Still open:
P2POOL_NODE_HOSTNAMEvalidation — deliberately left out of #26 because hostname handling is entangled with the.local/Avahi removal (#14 / #15); cleaner to land the hostname check alongside that work.Keeping open for the hostname validation.
feat: validate P2POOL_NODE_HOSTNAME before building (closes #8) (#29)
ci: add tag-driven release pipeline; complete the changelog (closes #36…