Skip to content

Expand CI: run the test suite + shfmt (pin shellcheck) #6

Closed

Description

@VijitSingh97

Goal

.github/workflows/lint.yml only runs shellcheck on rigforge.sh + util/proposed-grub.sh. Broaden it to pithead's level.

Proposed

Acceptance

  • CI runs shellcheck + shfmt + the test suite on every PR.
  • shellcheck version pinned/reproducible.

Activity

  1. added this to the v1.0 milestone on Jun 3, 2026
  2. added
    infraDeployment, packaging, releases
    testingTests, CI, and test infrastructure
    on Jun 3, 2026
  3. added theissue type on Jun 3, 2026
  4. VijitSingh97 commented on Jun 6, 2026

    @VijitSingh97
    ContributorAuthor

    Partially addressed by #26 (which closes #5).

    The test-job part of this is done: .github/workflows/ci.yml now runs tests/run.sh (the new suite) and an opt-in Docker E2E on every PR, alongside the existing shellcheck lint. For reproducibility the actions/checkout action is pinned by SHA and the E2E base image by digest.

    Still open for this issue:

    • shfmt formatting check
    • pin shellcheck (the lint job currently uses the runner's preinstalled shellcheck)
    • (optional) compile-smoke job that builds the pinned XMRig

    Keeping open for shfmt + pinned shellcheck.

  5. added a commit that references this issue on Jun 7, 2026
    d4353d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    infraDeployment, packaging, releasestestingTests, CI, and test infrastructure

    Type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions