Skip to content

chore: audit smalls — stale comment, resolved verify-upstream marker, orphan images - #989

Merged
VijitSingh97 merged 2 commits into
developfrom
chore/audit-smalls
Aug 14, 2026
Merged

chore: audit smalls — stale comment, resolved verify-upstream marker, orphan images#989
VijitSingh97 merged 2 commits into
developfrom
chore/audit-smalls

Conversation

@VijitSingh97

Copy link
Copy Markdown
Collaborator

Three small items from the 2026-08-14 repo audit, each independently verified:

  • tari_client.py pointed at "the TODO" for a node-down indicator that shipped long ago (Dashboard should show when monerod / tari nodes are down #31, component health). The comment now names the shipped thing.
  • docs/workers.md carried the repo's last [TODO: verify upstream] marker. Verified against the RigForge tree today: _api_rigforge_block ships config_meta provenance (revision, source, last_change_id) but no control status object mirroring /status. The doc now states the verified fact — and the missing mirror is a real RigForge follow-up if the terminal-status reconciliation should ever fire.
  • images/dashboard.png / syncing.png / pithead-logo.svg: referenced by nothing in the tree (pre-rename leftovers; only pithead-mark.svg is used). Deleted — if docs: refresh screenshots and images to current dashboard/branding #479's refresh wants stand-ins, git history keeps them.

make lint-docs-voice and make lint-md pass.

🤖 Generated with Claude Code

VijitSingh97 and others added 2 commits August 14, 2026 16:00
…n images

- tari_client.py pointed at 'the TODO' for a node-down indicator that shipped
  long ago (#31, component health) — the comment now names the shipped thing.
- docs/workers.md carried the repo's last [TODO: verify upstream] marker;
  verified against the RigForge tree today: the enriched feed ships config_meta
  provenance but no control status object, so the doc now states the verified
  fact instead of the question.
- images/dashboard.png, images/syncing.png, images/pithead-logo.svg: referenced
  by nothing (pre-rename leftovers; only pithead-mark.svg is used). Deleted.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…eld list, closing-check flag

- tari_client.py: 'component health' is the #170 topology panel, which never
  reads reachable; the #31 node-down consumer is NodeHealthMonitor — name it.
- workers.md: config_meta's field list omitted changed_at; the parenthetical
  read as the complete set.
- releasing.md: the closing-check guidance still taught the two-expected-
  failures eyeball pattern on a miner-less bench; with --no-mining-asserts
  (#905) the sweep passes with zero failures, so teach that instead.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@VijitSingh97
VijitSingh97 merged commit 71d6a7b into develop Aug 14, 2026
16 checks passed
@VijitSingh97
VijitSingh97 deleted the chore/audit-smalls branch August 14, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant