fix(e2e): honest --no-miner skips + bench chain pre-flight (#905, #914) - #982
Merged
Conversation
…ded config with loud drift diff Three e2e-harness hardenings (#914, #905, #880): - #914: e2e.sh refuses to start when the bench chains are not at tip. Before anything is locked or borrowed, it reads both sync panels off the bench dashboard's /api/state; anything but done/done prints each chain's current/target and aborts, so a cold bench reads as an environment condition instead of burning the borrowed-rig hour on required-sync failures. --skip-preflight overrides. - #905: --no-miner now does what its help text promised. e2e.sh threads --no-mining-asserts into run.sh, which SKIPs the workers-online and stratum-hashes assertions with a logged notice (and skips their pointless waits); every other assertion stays binding. - #880: the bundle-seeding path resolves the current -> symlink with readlink -f so the log names the real per-version bundle dir, and the bundle-vs-canonical drift diff is now full dotted key paths (nested keys — the shape that actually bit: monero.view_key, dashboard.energy) and ALWAYS prints a verdict when both configs exist, including the clean "no key-level drift" arm. The shared jq filters live in lib.sh so the selftest pins them: the #914 summary against a representative /api/state payload, the #880 key-path diff against nested drift, symlink resolution, and the identical-configs empty-diff arm. docs/dev/integration-testing.md updated for all three. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parked-branch submission from the 2026-08-14 repo audit: the branch was finished 2026-08-13 (single self-contained commit with tests and docs) but no PR was ever opened.
--no-minernow threads--no-mining-assertsintorun.sh, so the flag actually skips the two mining assertions it promises to skip (workers online, stratum hashes) with a logged notice — everything else stays binding./api/stateand aborts unless both report done, so a matrix run can no longer burn a borrowed-rig hour against a syncing chain.--skip-preflightoverrides; the jq filter is pinned in selftest so it can't drift from the dashboard payload.readlink -fon thecurrent ->pointer, full dotted-key drift diff (the drift that bit was nested keys), always-print verdict.Ponytail-review: lean, nothing to cut.
Closes #905
Closes #914
🤖 Generated with Claude Code