Skip to content

Remove slf4j-simple from dependencies#14

Open
pcimcioch wants to merge 1 commit into
ozimov:masterfrom
pcimcioch:master
Open

Remove slf4j-simple from dependencies#14
pcimcioch wants to merge 1 commit into
ozimov:masterfrom
pcimcioch:master

Conversation

@pcimcioch

Copy link
Copy Markdown

slf4j-simple is logging implementation and it shouldn't be forced as library's transient, non-optional dependency.
Adding slf4j-simple was quite disruptive, as it basically breaks applications that include this library but use other slf4j implementations (like logback).
From what I can see, it should be enough to have commons-logging in dependencies, and slf4j-simple can be used for test dependencies.

@codecov-commenter

codecov-commenter commented Jun 18, 2020

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.81%. Comparing base (659f4ba) to head (3a21d3a).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #14   +/-   ##
=========================================
  Coverage     72.81%   72.81%           
  Complexity      116      116           
=========================================
  Files            20       20           
  Lines           515      515           
  Branches         38       38           
=========================================
  Hits            375      375           
  Misses          118      118           
  Partials         22       22           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@skjolber

Copy link
Copy Markdown

@robertotru any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants