Skip to content

fix: pre_hook (sync) make request mutable#825

Open
drahnr wants to merge 1 commit into
oxidecomputer:mainfrom
drahnr:bernhard-chore-mic-mut-hook
Open

fix: pre_hook (sync) make request mutable#825
drahnr wants to merge 1 commit into
oxidecomputer:mainfrom
drahnr:bernhard-chore-mic-mut-hook

Conversation

@drahnr

@drahnr drahnr commented Jun 8, 2024

Copy link
Copy Markdown
Contributor

Obsoletes #823

@ahl ahl left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sort of surprised that we don't have a test that validates this. What will existing users of pre_hook experience other than a type error if they've specified the type in their pre_hook closure or fn?

@drahnr

drahnr commented Jun 13, 2024

Copy link
Copy Markdown
Contributor Author

I'm sort of surprised that we don't have a test that validates this. What will existing users of pre_hook experience other than a type error if they've specified the type in their pre_hook closure or fn?

Can you rephrase, I am not sure I understand what your concern is. Do you want an interface check for the provided TokenStream or are you concern re change in behviour for existing users that expect an &Request as argument?

@ahl

ahl commented Jun 13, 2024

Copy link
Copy Markdown
Collaborator

If there is an existing user of the pre_hook interface, what will those users experience with this change? Will everything just work or will compilation fail with an error?

@drahnr

drahnr commented Jan 1, 2026

Copy link
Copy Markdown
Contributor Author

Happy new year!

Mildly belated response; the user won't see a delta, since a we can call any fn foo(&T) with foo(&mut t).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants