feat(workflow): add safe native role pipeline - #22
Open
Thibault1818 wants to merge 1 commit into
Open
Conversation
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supervisor -> Implementer -> ReviewerCLI workflow, with an optional Adviser bounded to one callgit diff --check, review the exact commit/diff hash, and revalidate target branch/SHA immediately before mergeNative integration evidence
test/integration/native-role-workflow.test.tslaunches the real ORCH TypeScript CLI as an OS subprocess. It places deterministic local executables namedcodexandclaudeon a temporaryPATH; production code starts them through its normalspawnpath. Each scenario creates a real temporary Git repository with a commit, real branches, a linkedgit worktree, real implementation commits, quality commands, and merges.HOME,TMPDIR, npm state, and proxy variables are isolated; no model account or network is used.Covered scenarios:
Checks
npm ci --ignore-scriptsnpm run typechecknpm test -- test/unit/domain/native-role-workflow.test.ts test/integration/native-role-workflow.test.ts(16 passed)npm test(129 files, 2107 passed, 2 skipped)npm run buildnpm audit(0 vulnerabilities)git diff --checkScope and limits
typecheckandtestscripts; optionallintis also run. Lifecycle scripts are disabled for dependency installation and quality-script invocation.distfiles.