feat(tui): add high-contrast light palette - #16
Merged
Conversation
There was a problem hiding this comment.
🎉 Thanks for your first PR to ORCH! We're excited to review your contribution.
Our CI will run automatically:
- ✅ TypeScript strict mode check (
tsc --noEmit) - ✅ Full test suite (1493+ tests via Vitest)
- ✅ ESM build verification
A maintainer will review your changes shortly. In the meantime, check the Contributing Guide to make sure everything is in order.
⭐ If you enjoy working with ORCH, a star on the repo goes a long way!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lightTUI palette for terminals with light backgroundsorch config global set palette lightCHANGELOG.mdrelease notes for the feature, fixes, security work, and validationWhy
The original light palette used a dark foreground on saturated amber and status fills, which made active and flashing tab labels fail readable contrast in several states. It also assigned the same value to gray and ghost, making semantic remapping ambiguous when switching away from the light palette. The dependency graph additionally needed patched versions of direct and transitive packages.
Impact
Users can run ORCH on light terminal backgrounds without unreadable active tabs or incorrect remapped colors. Existing Amber, Ocean, Forest, and Violet behavior remains unchanged. Global palette configuration remains backward-compatible and defaults to Amber when no valid value is stored.
Release notes
The
Unreleasedsection ofCHANGELOG.mdnow documents the light palette, contrast and remapping fixes, dependency hardening, regression coverage, PTY E2E validation, and coverage totals.Validation
npm ci --ignore-scriptsnpm run typechecknpx tsc -p tsconfig.test.json --noEmitnpm run buildnpm audit --audit-level=low: 0 vulnerabilitiesnpm audit signatures: 155 verified registry signatures and 37 verified attestations