feat(frontend): add confirm button to node config modal - #18
Merged
Conversation
The node configuration modal only closed via clicking the backdrop, the header close icon, or Escape, none of which are very discoverable. Add an explicit "Done" button in a footer area (using oc-button, like the rest of the panel) that closes the panel the same way the other close affordances do. Fields already live-bind to node.data, so the button's only job is to emit "close". Signed-off-by: Lukas Hirt <info@hirt.cz>
mzner
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NodeDetailsPanel.vue) previously closed only via clicking the overlay backdrop, the header X icon, or pressing Escape — none of which are very discoverable as a "confirm and finish configuring" action.Donebutton in a footer area, usingoc-button(variation="primary") for visual consistency with the rest of the panel and the app's existing conventions (e.g. the Save button inWorkflowBuilder.vue).node.datavia the existingfield()/actionParam()helpers and emitupdateimmediately, the new button's only job is to emit the samecloseevent the existing close affordances already emit, whichWorkflowBuilder.vuehandles by nulling outselectedNodeId.Test plan
frontend/tests/unit/NodeDetailsPanel.spec.ts(new — first component-mount test in this repo, establishes the@vue/test-utils+vue3-gettextmounting pattern for future component tests):Donebutton is rendered.closeexactly once.cd frontend && npm run test:unit— all 3 test files / 6 tests pass.cd frontend && npm run check:types— clean.cd frontend && npm run lint— clean.🤖 Generated with Claude Code