Skip to content

feat(frontend): add confirm button to node config modal - #18

Merged
LukasHirt merged 1 commit into
mainfrom
feat/node-config-modal-ok-button
Jul 24, 2026
Merged

feat(frontend): add confirm button to node config modal#18
LukasHirt merged 1 commit into
mainfrom
feat/node-config-modal-ok-button

Conversation

@LukasHirt

Copy link
Copy Markdown
Collaborator

Summary

  • The node configuration modal (NodeDetailsPanel.vue) previously closed only via clicking the overlay backdrop, the header X icon, or pressing Escape — none of which are very discoverable as a "confirm and finish configuring" action.
  • Adds an explicit Done button in a footer area, using oc-button (variation="primary") for visual consistency with the rest of the panel and the app's existing conventions (e.g. the Save button in WorkflowBuilder.vue).
  • Since the panel's fields already live-bind to node.data via the existing field()/actionParam() helpers and emit update immediately, the new button's only job is to emit the same close event the existing close affordances already emit, which WorkflowBuilder.vue handles by nulling out selectedNodeId.

Test plan

  • Added frontend/tests/unit/NodeDetailsPanel.spec.ts (new — first component-mount test in this repo, establishes the @vue/test-utils + vue3-gettext mounting pattern for future component tests):
    • Confirms the Done button is rendered.
    • Confirms clicking it emits close exactly once.
  • Verified test fails without the change (button doesn't exist) and passes after implementing it.
  • cd frontend && npm run test:unit — all 3 test files / 6 tests pass.
  • cd frontend && npm run check:types — clean.
  • cd frontend && npm run lint — clean.

🤖 Generated with Claude Code

The node configuration modal only closed via clicking the backdrop,
the header close icon, or Escape, none of which are very discoverable.
Add an explicit "Done" button in a footer area (using oc-button, like
the rest of the panel) that closes the panel the same way the other
close affordances do. Fields already live-bind to node.data, so the
button's only job is to emit "close".

Signed-off-by: Lukas Hirt <info@hirt.cz>
@LukasHirt
LukasHirt requested a review from a team as a code owner July 24, 2026 16:02
@LukasHirt LukasHirt self-assigned this Jul 24, 2026
@LukasHirt
LukasHirt merged commit 8c61011 into main Jul 24, 2026
5 checks passed
@LukasHirt
LukasHirt deleted the feat/node-config-modal-ok-button branch July 24, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants